wireless/80211: update the 80211 header

[anchao]

Summary

wireless/80211: update the 80211 header

Upstream from:
https://github.com/freebsd/freebsd-src/blob/main/sys/net80211/ieee80211.h

Signed-off-by: chao.an anchao@xiaomi.com

Impact

N/A

Testing

CI-check

[pkarashchenko]

This update is quite strange to me because many of structures that are in Linux header file (pointed in PR description) have __packed attribute while similar named structures i this PR are not equipped with packed.

[btashton]

We cannot have a GPL header from Linux that has just been reformatted and had the Apache header slapped on it.

Unless I am not understanding correctly this needs to be deleted ASAP.

[pkarashchenko]

The original file is introduced in:

commit 38948fb65460adc5062f46cb033b4af47ec09559
Author: Gregory Nutt <gnutt@nuttx.org>
Date:   Sun Apr 30 17:40:10 2017 -0600

    ieee802.11: Bring some BSD licensed header files in from FreeBSD.

So there is no problem with that. The issue is only about adding the changes from GPL taken as a source

[jerpelea]

@btashton in my understanding those definitions come from the standard and were implemented in linux. We will have the same definitions from the same standard even if we do not take them from the linux header. I think that we should filter out if there is something specific to linux in this header.

[jerpelea]

@pkarashchenko here is an example of BSD header
http://fxr.watson.org/fxr/source/net80211/ieee80211.h?v=FREEBSD-12-STABLE;im=1

[pkarashchenko]

Ok. I will take a look into BSD variant ASAP

[jerpelea]

@pkarashchenko https://mentor.ieee.org/802.11/documents

[pkarashchenko]

@jerpelea @xiaoxiang781216 @anchao
I took a look into BSD variant of a header. As it was expected it as similar definitions and types/enums. So from this perspective I do not have any preferences either sync with Linux or BSD variant. But Linux variant has also a code (inline functions) that we are trying to adopt with this PR and from this perspective I definitely vote to sync with BSD variant.

[pkarashchenko]

Seems like initial file was taken from OpenBSD http://fxr.watson.org/fxr/source/net80211/ieee80211.h?v=OPENBSD
At least when I compare it with NuttX version with OpenBSD / NetBSD / FreeBSD the NetBSD has the best match.
Again, I think we should sync with FreeBSD as it is maintained and matches the best from license perspective

[anchao]

Seems like initial file was taken from OpenBSD http://fxr.watson.org/fxr/source/net80211/ieee80211.h?v=OPENBSD At least when I compare it with NuttX version with OpenBSD / NetBSD / FreeBSD the NetBSD has the best match. Again, I think we should sync with FreeBSD as it is maintained and matches the best from license perspective

@pkarashchenko I updated ieee80211.h from freebsd, please review again.
https://github.com/freebsd/freebsd-src/blob/main/sys/net80211/ieee80211.h

[pkarashchenko]

Only one major comment about missing end_packed_struct. Other are minor style. In general LGTM

[anchao]

Only one major comment about missing end_packed_struct. Other are minor style. In general LGTM

All addressed! Thank you!

[xiaoxiang781216]

macOS ci always fail to "wget --quiet https://static.dev.sifive.com/dev-tools/riscv64-unknown-elf-gcc-8.3.0-2019.08.0-x86_64-apple-darwin.tar.gz".
Since this patch isn't specific to macOS, let's merge this simple header file change patch instead.