env_dup: Allocate memory from the correct memory pool #5814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the initial proxy task is duplicated into the first user task, the environment exists in kernel memory and this must be copied to user memory. The memory allocated for the new task was allocated with the parent's priority which is incorrect. Use the new task's priority instead. Follow-up for: apache#5753
xiaoxiang781216
approved these changes
Mar 21, 2022
|
Maybe the best place is put into user space stack just like argument. |
pkarashchenko
approved these changes
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the initial proxy task is duplicated into the first user task,
the environment exists in kernel memory and this must be copied to user
memory.
The memory allocated for the new task was allocated with the parent's
priority which is incorrect. Use the new task's priority instead.
Follow-up for: #5753
Summary
Fix bug in environment duplication
Impact
Testing
Tested with icicle:knsh (CONFIG_BUILD_KERNEL=y), e.g. ls fails because the working directory name resides in kernel memory.