Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

signal: Don't do schedule_sigaction when there is no action #5887

Merged
merged 2 commits into from
Mar 30, 2022

Conversation

GUIDINGLI
Copy link
Contributor

Summary

signal: Don't do schedule_sigaction when there is no action
task: don't set default signal in kernal thread

We think, the kernel thread should set default signal action, like SIGINT SIGSTOP...

Impact

signal on kernel thread

Testing

VELA

Signed-off-by: ligd <liguiding1@xiaomi.com>
Signed-off-by: ligd <liguiding1@xiaomi.com>
@pkarashchenko
Copy link
Contributor

@masayuki2009 san, please review this change.

@masayuki2009
Copy link
Contributor

@GUIDINGLI

signal: Don't do schedule_sigaction when there is no action
task: don't set default signal in kernal thread

We think, the kernel thread should set default signal action, like SIGINT SIGSTOP...

Can you explain more about this PR?
Does this PR fix a bug or just refactoring?

@GUIDINGLI
Copy link
Contributor Author

@GUIDINGLI

signal: Don't do schedule_sigaction when there is no action
task: don't set default signal in kernal thread
We think, the kernel thread should set default signal action, like SIGINT SIGSTOP...

Can you explain more about this PR? Does this PR fix a bug or just refactoring?

Suppose you are confused with this patch:
signal: Don't do schedule_sigaction when there is no action

This just a improvement.
If the nxsig_queue_action don't actually queue a action, then we don't need do up_schedule_sigaction any more.

@masayuki2009 masayuki2009 merged commit e9f1794 into apache:master Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants