arm/chip: add backtrace support for all chips that support thumb instruction set. #5918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no1wudi
reviewed
Mar 31, 2022
CV-Bowen
changed the title
…ruction set. Signed-off-by: wangbowen6 <wangbowen6@xiaomi.com>
xiaoxiang781216
approved these changes
Apr 2, 2022
|
Seems that Cortex-A8 arch is missing. Maybe some other that support thumb. Need to re-check |
|
Cortex-A8 could be compiled with either arm or thumb, so we need select the different backtrace algo. |
|
Ok. I see. So the current implementation handles only the thumb variant and does not support arm or arm-thumb interworking. |
|
Yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
add backtrace support for all chips that support thumb instruction set.
Impact
Testing
nucleo-144 f746zg board, pass ci