Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cibuild.sh: Install ESPTOOL V3.0 #6281

Merged
merged 1 commit into from May 17, 2022
Merged

cibuild.sh: Install ESPTOOL V3.0 #6281

merged 1 commit into from May 17, 2022

Conversation

Ouss4
Copy link
Member

@Ouss4 Ouss4 commented May 16, 2022 •
edited

Summary

V4 deprecated python2 which is problematic in macOS.

Impact

Fix current CI breakage.

Testing

CI Workflow.

@Ouss4 Ouss4 marked this pull request as draft May 16, 2022 19:39
@Ouss4
Copy link
Member Author

Ouss4 commented May 16, 2022 •
edited

esptool.py not found. Please run: "pip install esptool"

Finally, the issue is that esptool is somehow not installed, even though we do have apip3 install esptool.

esptool installtion seems to fail with the newest 4.0 version.

So, latest version of esptool deprecated python2 which comes installed with macos.

@Ouss4 Ouss4 force-pushed the ci branch 8 times, most recently from 91d28b5 to ad90eea Compare May 16, 2022 23:33
@Ouss4 Ouss4 changed the title [DNM]: Verbose CI build cibuild.sh: Install ESPTOOL V3.0 May 16, 2022
@Ouss4 Ouss4 marked this pull request as ready for review May 16, 2022 23:34
This was referenced May 17, 2022
Merged
Merged
@Ouss4
Copy link
Member Author

Ouss4 commented May 17, 2022 •
edited

We're not done with CI failures today, looks like phy6222 was unable to download its library.

@pkarashchenko
Copy link
Contributor

Seems that "ESPTOOL V3.0" change is missing or not needed. Could you please update the commit message and PR description?

@Ouss4
Copy link
Member Author

Ouss4 commented May 17, 2022

Seems that "ESPTOOL V3.0" change is missing or not needed. Could you please update the commit message and PR description?

I was just trying something else to install V4. But that failed, so I restored the other change that installs V3.

@Ouss4 Ouss4 force-pushed the ci branch 8 times, most recently from 7069fbd to 3f12b7c Compare May 17, 2022 12:08
gustavonihei
gustavonihei reviewed May 17, 2022
View reviewed changes
tools/ci/cibuild.sh Outdated Show resolved Hide resolved
@Ouss4
xtensa.h: Remove old prototype.
9ad287d 
Signed-off-by: Abdelatif Guettouche <abdelatif.guettouche@espressif.com>
@xiaoxiang781216 xiaoxiang781216 merged commit 53cf328 into apache:master May 17, 2022
@Ouss4
Copy link
Member Author

Ouss4 commented May 17, 2022

Ah, I ended up messing the commit message when rebasing!

@Ouss4 Ouss4 deleted the ci branch May 17, 2022 17:13
This was referenced May 17, 2022
Merged
Merged
@jerpelea jerpelea added this to To-Add in Release Notes - 11.0.0 Aug 30, 2022
@jerpelea jerpelea moved this from To-Add to Added in Release Notes - 11.0.0 Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavonihei gustavonihei gustavonihei left review comments

@pkarashchenko pkarashchenko pkarashchenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Release Notes - 11.0.0
Added
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ouss4 @pkarashchenko @gustavonihei @xiaoxiang781216