New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pthread/spinlock: Call up_testsest directly in the flat build #6283
Conversation
@xiaoxiang781216 a fix for the macOS failure on ESP32 configs is here: #6281 however I see other ARM related changes, seem to be build related. |
Done. |
53babed
to
998bacf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good.
I'm just wondering if arch_atomic.c
is the best place for the up_testset
function.
cc. @gustavonihei
Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
up_testset is one of atomic function. Actually, it isn't good to introduce up_testset since atomic is part of C/C++ standard. It's better to use the standard atomic api, and implement them on the old toolchain by hand. |
The part that makes this new location a bit weird is that
So another option would be to leave |
Ok, I drop up_testset from PR, let's create a new PR to remove up_testset and call atomic api in spinlock instead. |
Here is #6283 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
be315dd
to
2e99215
Compare
Recursion. :) |
should be #6301 :) |
Summary
Impact
spinlock
Testing
Pass CI