Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LCD / SSD1306 added (re)configure IOCTL #6315

Closed
wants to merge 1 commit into from

Conversation

cisvanmierlo
Copy link
Contributor

Summary

Added IOCTL to (re)configure the display.
This is needed if for example the voltage domain of the display is not active during NuttX initialization.

Impact

Extended current implementation with an extra IOCTL.

Testing

Tested on a custom S32K1xx board.

@@ -782,7 +783,7 @@ static int ssd1306_setpower(FAR struct lcd_dev_s *dev, int power)
{
/* Configure display and turn the display on */

ret = ssd1306_configuredisplay(priv);
ret = ssd1306_configuredisplay(dev);
Copy link
Contributor

@xiaoxiang781216 xiaoxiang781216 May 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the delay configuration here not work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @xiaoxiang781216,

In our case, this SSD1306 display is pulling power from the I2C lines because the supply voltage of the display is not active yet.
This causes the I2C transactions to look OK, but in fact it is not being configured correctly.

I've checked, but there is no way to read out this display if it went OK.

We thought of a better solution and opened an other PR, see closing comment.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If so, look like you have to turn on the display power before i2c transaction and turn off the display power after i2c. Of course, you need some form of reference counting, so the display power doesn't turn off prematurely if it's really used.

@cisvanmierlo
Copy link
Contributor Author

Closed and replaced by PR #6319

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants