Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arch: Change the linker generated symbols from uint32_t to uint8_t * #7160

Merged
merged 1 commit into from
Sep 24, 2022
Merged

arch: Change the linker generated symbols from uint32_t to uint8_t * #7160

merged 1 commit into from
Sep 24, 2022

Conversation

xiaoxiang781216
Copy link
Contributor

@xiaoxiang781216 xiaoxiang781216 commented Sep 22, 2022 •
edited
Loading

Summary

The symbol generated by linker is always used as an address not a value.

Impact

Code refactor

Testing

Pass CI

@xiaoxiang781216
Copy link
Contributor Author

Please ignore this warning:
/home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/arm/src/phy62xx/start.c:169:6: error: Mixed case identifier found

pkarashchenko
pkarashchenko reviewed Sep 22, 2022
View reviewed changes
arch/arm/src/cxd56xx/cxd56_allocateheap.c Show resolved Hide resolved
arch/arm/src/cxd56xx/cxd56_farapi.c Outdated Show resolved Hide resolved
arch/arm/src/cxd56xx/cxd56_farapi.c Outdated Show resolved Hide resolved
arch/arm/src/rtl8720c/ameba_nvic.c Show resolved Hide resolved
arch/arm/src/samd2l2/sam_start.c Outdated Show resolved Hide resolved
arch/arm/src/stm32l4/stm32l4_start.c Outdated Show resolved Hide resolved
arch/arm/src/stm32wb/stm32wb_start.c Outdated Show resolved Hide resolved
arch/arm/src/tlsr82/tlsr82_start.c Outdated Show resolved Hide resolved
arch/arm/src/xmc4/xmc4_start.c Outdated Show resolved Hide resolved
libs/libc/misc/lib_cxx_initialize.c Outdated Show resolved Hide resolved
lucasssvaz added a commit to lucasssvaz/nuttx that referenced this pull request Sep 23, 2022
@lucasssvaz
boards/esp32-lyrat: Changed board_memorymap.h according to apache#7160
dce3077
xiaoxiang781216 pushed a commit that referenced this pull request Sep 23, 2022
@lucasssvaz @xiaoxiang781216
boards/esp32-lyrat: Changed board_memorymap.h according to #7160
0c33a93
gustavonihei
gustavonihei approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@gustavonihei gustavonihei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gustavonihei
gustavonihei requested changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@gustavonihei gustavonihei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revoking the approval due to another issue raised by the CI

gustavonihei
gustavonihei approved these changes Sep 23, 2022
View reviewed changes
Copy link
Contributor

@gustavonihei gustavonihei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaoxiang781216
arch: Change the linker generated symbols from uint32_t to uint8_t *
1eeed09 
and remove the duplicated declaration

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@pkarashchenko pkarashchenko merged commit 70290b6 into apache:master Sep 24, 2022
@gustavonihei gustavonihei mentioned this pull request Sep 29, 2022
Merged
This was referenced Oct 5, 2022
Merged
Merged
@acassis acassis mentioned this pull request Feb 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anchao anchao Awaiting requested review from anchao

@pkarashchenko pkarashchenko Awaiting requested review from pkarashchenko

@gustavonihei gustavonihei Awaiting requested review from gustavonihei

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaoxiang781216 @pkarashchenko @gustavonihei