Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: Ensure removing Python related commands for macOS #7971

Merged
merged 1 commit into from
Dec 24, 2022
Merged

tools: Ensure removing Python related commands for macOS #7971

merged 1 commit into from
Dec 24, 2022

Conversation

pkarashchenko
Copy link
Contributor

@pkarashchenko pkarashchenko commented Dec 24, 2022 •
edited
Loading

Summary

Fix MAC OS CI errors

Impact

MAC OS CI works with no errors

Testing

Pass CI

@pkarashchenko pkarashchenko changed the title tools: fix brew link error for idle3 tools: force update packges with brew Dec 24, 2022
@pkarashchenko pkarashchenko changed the title tools: force update packges with brew tools: fix brew link for python3 packages Dec 24, 2022
@pkarashchenko pkarashchenko force-pushed the fix_mac_build branch 2 times, most recently from a0f4583 to 0deb069 Compare December 24, 2022 16:55
@pkarashchenko pkarashchenko changed the title tools: fix brew link for python3 packages tools: brew force install ccache to fix python upgrade dependencies Dec 24, 2022
@pkarashchenko pkarashchenko changed the title tools: brew force install ccache to fix python upgrade dependencies tools: Ensure removing Python related commands for macOS Dec 24, 2022
@pkarashchenko
tools: Ensure removing Python related commands for macOS
cecbbef 
Signed-off-by: Petro Karashchenko <petro.karashchenko@gmail.com>
@pkarashchenko pkarashchenko marked this pull request as ready for review December 24, 2022 17:59
@pkarashchenko
Copy link
Contributor Author

@xiaoxiang781216 @hartmannathan the macOS CI should work with this PR, but I'm still wondering why Build Documentation fails. I tried to dry-run github workflow locally and Build Documentation seems to be passing however it fails on CI. Do you have any ideas?

@pkarashchenko
Copy link
Contributor Author

Just found WordPress/openverse-api#1058
Let's monitor this for some time.

@btashton
Copy link
Contributor

@xiaoxiang781216 @hartmannathan the macOS CI should work with this PR, but I'm still wondering why Build Documentation fails. I tried to dry-run github workflow locally and Build Documentation seems to be passing however it fails on CI. Do you have any ideas?

I will sort the documentation one. I have some context on that from when I was fixing it up last time. Might be after the weekend, but I'm on holiday now so, have time.

@xiaoxiang781216 xiaoxiang781216 merged commit b52aa1b into apache:master Dec 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaoxiang781216 xiaoxiang781216 xiaoxiang781216 approved these changes

@hartmannathan hartmannathan Awaiting requested review from hartmannathan

@acassis acassis Awaiting requested review from acassis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pkarashchenko @btashton @xiaoxiang781216