Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sched: group: Fix memory corruption in group_leave.c #7997

Merged
merged 1 commit into from
Dec 29, 2022

Conversation

masayuki2009
Copy link
Contributor

Summary

Impact

  • Should be none

Testing

  • Tested with spresense:wifi_smp

Summary:
- I noticed that nxplayer (HTTP audio streaming) + command execution
  via telnet sometimes causes memory corruption.
  See apache#7947 for the detail.
- This commit fixes this issue by calling lib_stream_release() before
  lib_stream_release() in group_leave.c

Impact:
- Should be none

Testing:
- Tested with spresense:wifi_smp

Signed-off-by: Masayuki Ishikawa <Masayuki.Ishikawa@jp.sony.com>
@xiaoxiang781216
Copy link
Contributor

Thanks to fix the crash.

@xiaoxiang781216 xiaoxiang781216 merged commit 6992a8f into apache:master Dec 29, 2022
@pussuw
Copy link
Contributor

pussuw commented Jan 2, 2023

@masayuki2009 Thank you so much for fixing this crash!

@masayuki2009 masayuki2009 deleted the fix_group_release branch January 11, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants