mm/mempool: fix crash by kasan report and enhance mempool #8116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the crash backtrace: kasan_report (addr=0xf3d02fd4, size=4, is_write=false) at kasan/kasan.c:106 0x5658518d in __asan_loadN_noabort (addr=0xf3d02fd4, size=4) at kasan/kasan.c:300 0x565851ee in __asan_load4_noabort (addr=0xf3d02fd4) at kasan/kasan.c:334 0x56580b02 in sq_remfirst (queue=0xf3d02b08) at queue/sq_remfirst.c:45 0x565e0e0b in mempool_alloc (pool=0xf3d02aec) at mempool/mempool.c:161 0x566033d2 in mempool_multiple_alloc (mpool=0xf3d02a30, size=16) at mempool/mempool_multiple.c:147 Signed-off-by: dongjiuzhu1 <dongjiuzhu1@xiaomi.com>
Let's specify size instead of number, so that we can unify the size of expansion memory in the multiple mempool. Signed-off-by: dongjiuzhu1 <dongjiuzhu1@xiaomi.com>
This delta describes the relationship between the block size of each mempool in multiple mempool by user initialized. It is automatically detected by the mempool_multiple_init function. If the delta is not equal to 0, the block size of the pool in the multiple mempool is an arithmetic progressions, otherwise it is an increasing progressions. Signed-off-by: dongjiuzhu1 <dongjiuzhu1@xiaomi.com>
kasan_report (addr=0xf3c68618, size=1, is_write=false) at kasan/kasan.c:106 0x56585fbf in __asan_loadN_noabort (addr=0xf3c68618, size=1) at kasan/kasan.c:300 0x565860ac in __asan_load1_noabort (addr=0xf3c68618) at kasan/kasan.c:354 0x565843af in memcpy (dest=0xf3de9d6c, src=0xf3c685cc, n=3) at string/lib_memcpy.c:44 0x56587ae8 in mempool_multiple_realloc (mpool=0xf3c670fc, oldblk=0xf3c685cc, size=416) at mempool/mempool_multiple.c:218 0x5658707a in mm_realloc (heap=0xf3c67000, oldmem=0xf3c685cc, size=416) at mm_heap/mm_realloc.c:98 0x5658524e in realloc (oldmem=0xf3c685cc, size=416) at umm_heap/umm_realloc.c:97 Signed-off-by: dongjiuzhu1 <dongjiuzhu1@xiaomi.com>
The memalign is special to multiple mempool because multiple mempool doesn't support split and shrink chunk operate. So When you alloc a memory block and find an aligned address in this block, you need to occupy 8 bytes before the address to save the address of the padding size and pool to ensure correct use in realloc and free operations. So we will use bit1 in the previous address of the address to represent that it is applied by memalign. Signed-off-by: dongjiuzhu1 <dongjiuzhu1@xiaomi.com>
Donny9
changed the title
xiaoxiang781216
approved these changes
Jan 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bug fixes and enhancements related to mempool based on #7450.
After this pr, I will submit the patch related to the global mempool.
Impact
Enhance mempool
Testing
daily test.