Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for stm32h7 socket CAN error handling. #8250

Merged
merged 1 commit into from
Jan 30, 2023

Conversation

rajvindervirk
Copy link
Contributor

Summary

Added socket CAN error handling for stm32h7. It follows the same approach as stm32.

Impact

The error frames are send to socket interface if an error occurs.

Testing

Tested functionality on stm32h7 board. Error frames are received by the application with the information in the appropriate bits.

@xiaoxiang781216
Copy link
Contributor

@rajvindervirk please squash your change into one patch.

Copy link
Contributor

@raiden00pl raiden00pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides some coding style problems LGTM

arch/arm/src/stm32h7/stm32_fdcan_sock.c Outdated Show resolved Hide resolved
arch/arm/src/stm32h7/stm32_fdcan_sock.c Outdated Show resolved Hide resolved
arch/arm/src/stm32h7/stm32_fdcan_sock.c Outdated Show resolved Hide resolved
arch/arm/src/stm32h7/stm32_fdcan_sock.c Outdated Show resolved Hide resolved
arch/arm/src/stm32h7/stm32_fdcan_sock.c Outdated Show resolved Hide resolved
arch/arm/src/stm32h7/stm32_fdcan_sock.c Outdated Show resolved Hide resolved
arch/arm/src/stm32h7/stm32_fdcan_sock.c Outdated Show resolved Hide resolved
arch/arm/src/stm32h7/stm32_fdcan_sock.c Outdated Show resolved Hide resolved
arch/arm/src/stm32h7/stm32_fdcan_sock.c Outdated Show resolved Hide resolved
include/nuttx/can.h Outdated Show resolved Hide resolved
@rajvindervirk
Copy link
Contributor Author

I have addressed your suggestions. Back to you.

@xiaoxiang781216
Copy link
Contributor

@rajvindervirk you can directly amend the change to the first patch.

@rajvindervirk
Copy link
Contributor Author

@xiaoxiang781216 - I have amended the change to the first patch.

@xiaoxiang781216 xiaoxiang781216 merged commit 2b30f17 into apache:master Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants