Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/slip: Change SLIP to use IOB #8344

Merged
merged 1 commit into from Jan 30, 2023

Conversation

wengzhe
Copy link
Contributor

@wengzhe wengzhe commented Jan 30, 2023

Summary

SLIP seems to be broken after IOB offload (#8239), try to fix it.

Impact

Change SLIP device to use IOB

Testing

No actual boards for testing, may need your help to confirm whether it works.

@xiaoxiang781216
Copy link
Contributor

@michi-jung could you help us verify this patch?

@michi-jung
Copy link
Contributor

@michi-jung could you help us verify this patch?

Hi @xiaoxiang781216 and @wengzhe. Yes, patch is working fine for me. Thanks!

Could you please increase the buffer array in slip_initialize to 12 characters to silence compiler warnings about potentially truncated output (INT_MIN requires 11 chars + NUL)? Thanks!

Signed-off-by: Zhe Weng <wengzhe@xiaomi.com>
@wengzhe
Copy link
Contributor Author

wengzhe commented Jan 30, 2023

@michi-jung could you help us verify this patch?

Hi @xiaoxiang781216 and @wengzhe. Yes, patch is working fine for me. Thanks!

Could you please increase the buffer array in slip_initialize to 12 characters to silence compiler warnings about potentially truncated output (INT_MIN requires 11 chars + NUL)? Thanks!

@michi-jung Updated, it this what you need?

@michi-jung
Copy link
Contributor

@michi-jung could you help us verify this patch?

Hi @xiaoxiang781216 and @wengzhe. Yes, patch is working fine for me. Thanks!
Could you please increase the buffer array in slip_initialize to 12 characters to silence compiler warnings about potentially truncated output (INT_MIN requires 11 chars + NUL)? Thanks!

@michi-jung Updated, it this what you need?

@wengzhe Yes, exactly. Thanks!

@xiaoxiang781216 xiaoxiang781216 merged commit af0a35f into apache:master Jan 30, 2023
@jerpelea jerpelea added this to To-Add in Release Notes - 12.1.0 Apr 3, 2023
@jerpelea jerpelea moved this from To-Add to Added in Release Notes - 12.1.0 Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants