Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/devif: check the net device before use #8361

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

anchao
Copy link
Contributor

@anchao anchao commented Jan 30, 2023

Summary

net/devif: check the net device before use

Signed-off-by: chao an anchao@xiaomi.com

Impact

N/A

Testing

tcp/udp test

net/devif/devif_iobsend.c Show resolved Hide resolved
Signed-off-by: chao an <anchao@xiaomi.com>
@xiaoxiang781216 xiaoxiang781216 merged commit 7fce145 into apache:master Jan 31, 2023
@masayuki2009
Copy link
Contributor

@anchao

I noticed that the renew command with lm3s6965-ek:discover on QEMU-7.1 does not work with this PR.

nsh> uname -a
NuttX  10.4.0 7fce145b30 Jan 31 2023 20:35:26 arm lm3s6965-ek
nsh> ps
  PID GROUP PRI POLICY   TYPE    NPX STATE    EVENT     SIGMASK   STACK   USED  FILLED COMMAND
    0     0   0 FIFO     Kthread N-- Ready              00000000 001000 000472  47.2%  Idle Task
    1     1 224 RR       Kthread --- Waiting  Semaphore 00000000 001992 000276  13.8%  hpwork 0x20001cd0
    2     2  60 RR       Kthread --- Waiting  Semaphore 00000000 001992 000276  13.8%  lpwork 0x20001ce8
    3     3 100 RR       Task    --- Running            00000000 002000 001160  58.0%  nsh_main
    4     4 100 RR       Task    --- Waiting  Semaphore 00000000 002008 000564  28.0%  telnetd
nsh> ifconfig
eth0	Link encap:Ethernet HWaddr 00:e0:de:ad:be:ef at UP
	inet addr:10.0.0.2 DRaddr:10.0.0.1 Mask:255.255.255.0

             IPv4   TCP   UDP  ICMP
Received     0000  0000  0000  0000
Dropped      0000  0000  0000  0000
  IPv4        VHL: 0000   Frg: 0000
  Checksum   0000  0000  0000  ----
  TCP         ACK: 0000   SYN: 0000
              RST: 0000  0000
  Type       0000  ----  ----  0000
Sent         0000  0000  0000  0000
  Rexmit     ----  0000  ----  ----
nsh> renew eth0
ERROR: dhcpc_request() failed

@anchao
Copy link
Contributor Author

anchao commented Jan 31, 2023

@anchao

I noticed that the renew command with lm3s6965-ek:discover on QEMU-7.1 does not work with this PR.

Could you please share the qemu command line?

@masayuki2009
Copy link
Contributor

@anchao

Could you please share the qemu command line?

/home/ishikawa/opensource/QEMU/qemu-7.1/build/arm-softmmu/qemu-system-arm -net nic,model=stellaris -net user,hostfwd=tcp::20023-:23,hostfwd=tcp::20021-:21,hostfwd=tcp::25001-:5001 -M lm3s6965evb -kernel ./nuttx -nographic

@anchao
Copy link
Contributor Author

anchao commented Jan 31, 2023

@anchao

Could you please share the qemu command line?

/home/ishikawa/opensource/QEMU/qemu-7.1/build/arm-softmmu/qemu-system-arm -net nic,model=stellaris -net user,hostfwd=tcp::20023-:23,hostfwd=tcp::20021-:21,hostfwd=tcp::25001-:5001 -M lm3s6965evb -kernel ./nuttx -nographic

@masayuki2009 thank you, please review #8380

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants