fs: Undefine CONFIG_FS_LARGEFILE if compiler doesn't support long long #8656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to simplify the large file check in many place Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
acassis
approved these changes
Feb 26, 2023
|
Nice improvement, it makes the code easier to read! |
jerpelea
approved these changes
Mar 2, 2023
Comment on lines
+947
to
+950
| #ifndef CONFIG_HAVE_LONG_LONG | ||
| # undef CONFIG_FS_LARGEFILE | ||
| #endif | ||
|
|
There was a problem hiding this comment.
Why not
config FS_LARGEFILE
bool "Large File Support"
default n
depends on HAVE_LONG_LONG
in Kconfig instead?
There was a problem hiding this comment.
Can not since HAVE_LONG_LONG isn't a Kconfig option, but define in:
https://github.com/apache/nuttx/blob/master/include/nuttx/compiler.h#L283
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
to simplify the large file check in many place
Impact
code refactory only
Testing
CI