drivers/serial: Echo CR when NL is detected and the serial device is a console #8718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Echoing console's input is now performed by the serial driver (apache#8691). In order to keep old behavior of CR being echoed by the device, it's needed to detected whenever NL is being echoed and send CR before sending it.
acassis
approved these changes
Mar 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Echo CR when NL is detected and the serial device is a console and fix #8691 (comment)
Impact
The serial driver now performs the echoing console's input (#8691). In order to keep the old behavior of CR being echoed by the device, it's necessary to detect whenever NL is being echoed and send CR before sending it.
Testing
Internal CI, NuttX's CI and test on ESP32-DevKitC.