ACT8945A: Correct DEBUGASSERT code error, plus tidy ups #8742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkarashchenko
approved these changes
Mar 6, 2023
pkarashchenko
approved these changes
Mar 6, 2023
|
Please squash commits |
…bility Update drivers/power/supply/act8945a.c Co-authored-by: Petro Karashchenko <petro.karashchenko@gmail.com>
TimJTi
force-pushed
the
ACT8945A-error-fixes
branch
from
7219203
to
39efa57
Compare
|
The C89 issue is not fixed. Anyway I can try to get back compatibility later |
I was trying to force the build to enforce strict c89 but have not worked out how to do that? Arm gcc, Linux. What is not compliant still - I am happy to fix once I understand :) |
xiaoxiang781216
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Found a silly DEBUGASSERT logical error.
Whilst correcting this spotted a _err formatting warning; fixed and slightly amended it to fix the warning. Also attempted to fix a previously raised concern about C89 compatibility.
Impact
None, unless you have DEBUGASSERTS enabled in which case it will no longer assert because of the error.
Testing
Custom board: SAMA5D27C-D1G with act8945a regulator