usbdev/composite: composite should send only one request for USB_REQ_SETCONFIGURATION #8883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
usbdev-composite: ep0 submit should be send only once for the composite class
Some of USB controllers handle USB_REQ_SETCONFIGURATION by hardware, so we had a situation that some of composite configurations worked (eg. spresense) but other not (eg. stm32 otg).
I think this problem was quite old (probably related thread on the old mailing list - https://nuttx.yahoogroups.narkive.com/Y6ZpMpFe/composite-usb-device-on-stm32f4-issues and annoing to find.
rndis: use composite_ep0submit to send the ep0 when composite
Impact
Testing
composite rndis + cdcacm on stm32 OTG