Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ostest: Enabled KASAN, UBSAN & assertions. #8972

Merged
merged 1 commit into from Apr 18, 2023

Conversation

fjpanag
Copy link
Contributor

@fjpanag fjpanag commented Apr 5, 2023

Summary

Enables KASAN, UBSAN and assertions in ostest, in the hope that more errors could be found faster and easier.

Impact

Better testing.

Testing

I run ostest in sim with this exact configuration.
The test passes without issues.

@davids5
Copy link
Contributor

davids5 commented Apr 6, 2023

@fjpanag CI Error is
clang: error: unsupported option '-fsanitize=kernel-address' for target 'x86_64-apple-darwin21.6.0'

@fjpanag
Copy link
Contributor Author

fjpanag commented Apr 6, 2023

@fjpanag CI Error is clang: error: unsupported option '-fsanitize=kernel-address' for target 'x86_64-apple-darwin21.6.0'

I saw that, but I am not sure what is the best way to handle this.

Typically, Kconfig should handle it. Have the option depend on its prerequisites. But Kconfig does not know the compiler used.

It can be fixed in the Makefiles. However, the users will have the option enabled, but it won't work! It will very confusing.

Or maybe, the check could be disabled directly in CI for this specific build? Maybe with a kconfig-tweak before this build command?

@fjpanag
Copy link
Contributor Author

fjpanag commented Apr 12, 2023

I ended up disabling the ostest build in macOS...

I think that the CI failure is unrelated?

@fjpanag fjpanag marked this pull request as ready for review April 12, 2023 14:32
@xiaoxiang781216 xiaoxiang781216 merged commit 1530e04 into apache:master Apr 18, 2023
26 checks passed
@fjpanag fjpanag deleted the ostest branch April 19, 2023 09:05
@jerpelea jerpelea added this to To-Add in Release Notes - 12.2.0 Jun 13, 2023
@jerpelea jerpelea moved this from To-Add to In Progress in Release Notes - 12.2.0 Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants