Skip to content

Commit

Permalink
Improved: Remove unnecessary ‘ofbizDebug’ task type (OFBIZ-11302)
Browse files Browse the repository at this point in the history
the standard ‘--debug-jvm’ Gradle option already provides the same
functionality.
  • Loading branch information
mthl committed Dec 1, 2019
1 parent 81f82b1 commit 22f1da7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 16 deletions.
13 changes: 4 additions & 9 deletions README.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,6 @@ There are two types of tasks designed for OFBiz in Gradle:
* *OFBiz server tasks*: To execute OFBiz startup commands. These tasks start
with one of the following words:
* *ofbiz* : standard server commands
* *ofbizDebug* : server commands running in remote debug mode
* *ofbizBackground* ; server commands running in a background forked process

Tips:
Expand All @@ -175,7 +174,7 @@ tasks. Example: `gradlew loadAdminUserLogin -PuserLoginId=myadmin` =

`gradlew "ofbiz --help"`

`gradlew "ofbizDebug --test"`
`gradlew "ofbiz --test" --debug-jvm`

`gradlew "ofbizBackground --start --portoffset 10000"`

Expand Down Expand Up @@ -273,11 +272,7 @@ inconsistent state / data
Starts OFBiz in remote debug mode and waits for debugger or IDEs to connect on
port *5005*

`gradlew "ofbizDebug --start"`

OR

`gradlew ofbizDebug`
`gradlew ofbiz --debug-jvm`

[[start-ofbiz-on-a-different-port]]
==== Start OFBiz on a different port
Expand Down Expand Up @@ -514,7 +509,7 @@ run a test case, in this example the component is "entity" and the case name is

listens on port *5005*

`gradlew "ofbizDebug --test component=entity --test loglevel=verbose"`
`gradlew "ofbiz --test component=entity --test loglevel=verbose" --debug-jvm`

[[execute-an-integration-test-suite]]
==== Execute an integration test suite
Expand All @@ -526,7 +521,7 @@ listens on port *5005*

listens on port *5005*

`gradlew "ofbizDebug --test component=entity --test suitename=entitytests"`
`gradlew "ofbiz --test component=entity --test suitename=entitytests" --debug-jvm`



Expand Down
7 changes: 0 additions & 7 deletions build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -963,13 +963,6 @@ tasks.addRule('Pattern: ofbiz <Commands>: Execute OFBiz startup commands') { Str
}
}

tasks.addRule('Pattern: ofbizDebug <Commands>: Execute OFBiz startup commands in remote debug mode') { String taskName ->
if (taskName ==~ /^ofbizDebug\s.*/ || taskName == 'ofbizDebug') {
def arguments = (taskName - 'ofbizDebug').tokenize(' ')
createOfbizCommandTask(taskName, arguments).with { debug = true }
}
}

tasks.addRule('Pattern: ofbizBackground <Commands>: Execute OFBiz startup commands in background and output to console.log') { String taskName ->
if (taskName ==~ /^ofbizBackground\s.*/ || taskName == 'ofbizBackground') {
createOfbizBackgroundCommandTask(taskName)
Expand Down

0 comments on commit 22f1da7

Please sign in to comment.