OFBIZ-4035 change the id Attribute for input fields in the model macro form renderer from String to FlexibleStringExpander #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… can use ${} notation. Also document the default value if id-name is not set.
…rId() method rather than getIdName(). This allows use of ids generated from FlexibleStringExpander expressions.
|
Kudos, SonarCloud Quality Gate passed!
|
|
Hi Dan, it would be better to single out the documentation commit because this could be applied directly (as "Documented: ..."). The 2nd commit is already in PR 23 so could be removed (will need further review/decision). |
|
Please also use the commit message template (see issue comment). |
|
Closing this PR as will create a new PR focused on the documentation commit per @mbrohl suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functionality to render a DOM element's id attribute using a FlexibleStringExpander expression already existed in Ofbiz via ModelFormField#getCurrentContainerId.
This PR includes changes in widget-form.xsd to document that the id-name attribute can use ${} notation. It also adds a small unit test to ensure that getCurrentContainerId is processing id-name as a FlexibleStringExpander expression.