Fixed: Wrong Less file path for some theme/locale combinations (OFBIZ-12660) #521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florianMo
force-pushed
the
OFBIZ-12660
branch
3 times, most recently
from
bd9fd65
to
358c3e0
Compare
…-12660)
For some themes, we rely on toLowerCase method to build a Less file path.
toLowerCase("I") = "ı" for some locales (TR, AZ), which lead to incorrect
file paths and finally broken themes.
|
Kudos, SonarCloud Quality Gate passed!
|
asfgit
pushed a commit
that referenced
this pull request
Aug 10, 2022
…-12660) (#521) For some themes, we rely on toLowerCase method to build a Less file path. toLowerCase("I") = "ı" for some locales (TR, AZ), which lead to incorrect file paths and finally broken themes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: Wrong Less file path for some theme/locale combinations (OFBIZ-12660)
Fixed:
(OFBIZ-12660)
Explanation
For some themes, we rely on toLowerCase method to build a Less file path.
toLowerCase("I") = "ı" for some locales (TR, AZ), which lead to incorrect
file paths and finally broken themes.