Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OFBIZ-10954 Have a country dimension #1

Closed
wants to merge 1 commit into from
Closed

OFBIZ-10954 Have a country dimension #1

wants to merge 1 commit into from

Conversation

PierreSmits
Copy link
Member

This PR contains additions to

  1. the entity group
  2. the entity model

@sonarcloud
Copy link

sonarcloud bot commented Jan 29, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@pwverma
Copy link
Contributor

pwverma commented Jan 29, 2020

I am not having access to merge this PR, Do I need to setup something?

@JacquesLeRoux tagging you here as I saw you merge from github ;)

@swapnilmmane
Copy link
Member

I am not having access to merge this PR, Do I need to setup something?

@JacquesLeRoux tagging you here as I saw you merge from github ;)

Hi @verma-pawan,
You will need to link you ASF and GitHub account, please refer https://gitbox.apache.org/

@pwverma
Copy link
Contributor

pwverma commented Jan 29, 2020

I am not having access to merge this PR, Do I need to setup something?
@JacquesLeRoux tagging you here as I saw you merge from github ;)

Hi @verma-pawan,
You will need to link you ASF and GitHub account, please refer https://gitbox.apache.org/

Thanks, Swapnil for the information, I'll setup it soon :)

@PierreSmits
Copy link
Member Author

Thanks, @verma-pawan & @swapnilmmane, for your participation and support.

@JacquesLeRoux
Copy link
Contributor

JacquesLeRoux commented Jan 29, 2020

Hi @verma-pawan,

Beware that if you merge a PR from GitHub you will not be able to use our commit template, see https://markmail.org/message/nmadztprvucz4mlv for more

Thanks
PS: IMO a good way is to do it as Nicolas did at apache/ofbiz-framework#7 (comment). In other word, he did not merge in GitHub but followe our process where the commit template is used. Maybe this still needs discussion but for now I'd priviledge this way.

@swapnilmmane
Copy link
Member

+1 to @JacquesLeRoux's comment.

@verma-pawan and team,
I still feel, if possible we should avoid merging PR through GitHub, till we don't conclude the thread mentioned by Jacques (https://markmail.org/message/nmadztprvucz4mlv).

@pwverma
Copy link
Contributor

pwverma commented Jan 30, 2020

Thanks @JacquesLeRoux @swapnilmmane for the details. I have committed changes(Trunk#ccb6219954a0b523b8ff854da5954af2feaab8d0) of this PR using our pattern.
I have linked my ASF and GitHub accounts. Still, I am unable to see Merge and Close buttons for this PR. As changes of this PR has been committed this should be close. Thanks!

@pwverma
Copy link
Contributor

pwverma commented Jan 30, 2020

Got the access now. Thanks!

@pwverma pwverma closed this Jan 30, 2020
@PierreSmits PierreSmits deleted the OFBIZ-10954-Have-a-Country-Dimension branch January 30, 2020 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants