Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(services/s3): Add object versioning for S3 #4873

Merged
merged 6 commits into from
Jul 9, 2024
Merged

feat(services/s3): Add object versioning for S3 #4873

merged 6 commits into from
Jul 9, 2024

Conversation

Lzzzzzt
Copy link
Contributor

@Lzzzzzt Lzzzzzt commented Jul 9, 2024

This pull request add support of object versioning for S3

Part of #2611

Basically, done the following task

  • change the args of s3_delete_object to receive the version info
  • add versionId param of the url sent (get, head, del) to the s3 server
  • parse version info from head response and add it into metadata

Lzzzzzt and others added 6 commits July 9, 2024 09:10
@Lzzzzzt
feat: add object versioning support for oss
55535b2 
Signed-off-by: Lzzzt <liuzitao0123@gmail.com>
@Lzzzzzt
feat: add object versioning support for oss
8959213 
Signed-off-by: Lzzzt <liuzitao0123@gmail.com>
@Lzzzzzt
feat: add object versioning support for oss
b9467be 
Signed-off-by: Lzzzt <liuzitao0123@gmail.com>
@Lzzzzzt
feat: add object versioning support for oss
4f4a6fd 
Signed-off-by: Lzzzt <liuzitao0123@gmail.com>
@Lzzzzzt
feat: add Object versioning support for S3
4d551b0 
Signed-off-by: Lzzzt <liuzitao0123@gmail.com>
@Lzzzzzt
Merge branch 'apache:main' into object-versioning-s3
80f3a2b
@Lzzzzzt Lzzzzzt requested a review from Xuanwo as a code owner July 9, 2024 04:46
@Lzzzzzt Lzzzzzt changed the title feat(core): Add object versioning for S3 feat(services/s3): Add object versioning for S3 Jul 9, 2024
Xuanwo
Xuanwo approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 161e4ad into apache:main Jul 9, 2024
83 checks passed
@Xuanwo Xuanwo mentioned this pull request Jul 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@dqhl76 dqhl76 Awaiting requested review from dqhl76

@silver-ymz silver-ymz Awaiting requested review from silver-ymz

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lzzzzzt @Xuanwo