Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(services/s3)!: renamed security_token to session_token #4875

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

Zyyeric
Copy link
Contributor

@Zyyeric Zyyeric commented Jul 9, 2024

Rename security_token field in S3Config to session_token to be coherent with AWS STS naming, and set security_token as deprecated.

Related Issue: #4874

Signed-off-by: Zyyeric <eric1976808123@gmail.com>
Signed-off-by: Zyyeric <eric1976808123@gmail.com>
@Xuanwo Xuanwo changed the title refactor(services/s3): renamed security_token to session_token refactor(services/s3)!: renamed security_token to session_token Jul 9, 2024
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 3bc2605 into apache:main Jul 10, 2024
82 checks passed
@Zyyeric Zyyeric deleted the rename branch July 10, 2024 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants