Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed helptext after resolved problem. #117

Merged
merged 1 commit into from
Mar 2, 2021
Merged

Conversation

DiGro
Copy link
Contributor

@DiGro DiGro commented Jan 9, 2021

[:space:] should represent any whitespace character in regular expressions.
However, in the older, before OOo 3.4, it did not find the tab \t.

Now it does due to changing the regexp engine since 3.4

[:space:] should represent any whitespace character in regular expressions.
However, in the older, before OOo 3.4, it did not find the tab \t.

Now it does due to changing the regexp engine since 3.4
@ardovm ardovm self-requested a review February 28, 2021 21:13
Copy link
Contributor

@ardovm ardovm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. I propose merging it in 24 hours if no one raises any objections.

@Pilot-Pirx Pilot-Pirx self-requested a review March 1, 2021 16:17
Copy link
Member

@Pilot-Pirx Pilot-Pirx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK for me!

@ardovm ardovm merged commit 8a29a53 into apache:trunk Mar 2, 2021
ardovm pushed a commit to ardovm/openoffice that referenced this pull request Mar 2, 2021
[:space:] should represent any whitespace character in regular expressions.
However, in the older, before OOo 3.4, it did not find the tab \t.

Now it does due to changing the regexp engine since 3.4
ardovm pushed a commit that referenced this pull request Mar 2, 2021
[:space:] should represent any whitespace character in regular expressions.
However, in the older, before OOo 3.4, it did not find the tab \t.

Now it does due to changing the regexp engine since 3.4
@DiGro DiGro deleted the patch-1 branch March 4, 2021 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants