Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test compile #189

Merged
merged 2 commits into from
Jun 7, 2019
Merged

Fix test compile #189

merged 2 commits into from
Jun 7, 2019

Conversation

dubee
Copy link
Member

@dubee dubee commented Jun 6, 2019

Fix tests breakages related to apache/openwhisk@aeabc35.

dgrove-oss
dgrove-oss approved these changes Jun 6, 2019
View reviewed changes
Copy link
Member

@dgrove-oss dgrove-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dubee
Copy link
Member Author

dubee commented Jun 6, 2019

@jasonpet, build is failing with:

E: Unable to locate package nodejs
E: Unable to locate package npm
The command "./tools/travis/build.sh" exited with 100.

@jasonpet
Copy link
Contributor

jasonpet commented Jun 6, 2019 •
edited
Loading

@dubee - when I annotate the lines causing the issue it is showing @houshengbo as the author.

@dubee dubee merged commit f51b839 into apache:master Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgrove-oss dgrove-oss dgrove-oss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dubee @jasonpet @dgrove-oss