Auto supply a dummy API GW token #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrutkows
requested changes
Sep 10, 2019
parsers/manifest_parser.go
Outdated
| wski18n.ID_MSG_CONFIG_MISSING_APIGW_ACCESS_TOKEN) | ||
| warningString := wski18n.T(wski18n.ID_MSG_CONFIG_MISSING_APIGW_ACCESS_TOKEN) | ||
| wskprint.PrintOpenWhiskWarning(warningString) | ||
| client.ApigwAccessToken = "DUMMY TOKEN" |
There was a problem hiding this comment.
Could we make the string "DUMMY TOKEN" a package constant and also "wskprint" that we are using a default string with the value "DUMMY TOKEN" so it is clear utility is providing a default behavior (due to lack of explicit value)?
|
@jiangpengcheng Thanks for finding and making this correction. If you make these simple changes requested in the review comments, I plan to merge. |
jiangpengcheng
force-pushed
the
feature/dummy_gw_token
branch
from
0805ede
to
9317b6b
Compare
|
ok, I use a constant for the dummy token, and print a more clear message for users |
mrutkows
approved these changes
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
APIGW_ACCESS_TOKENis an optinal parameter, and the actionapimgmt/createApido require this parameter no matter what the value is, I think it's better to provide a fake token just like the openwhisk-cli did, see api.go:related to: #1037