Alphabetize listings in CLI #2326

underwoodb-sd-ibm · 2017-06-01T19:48:20Z

Alphabetize, coauthored by myself and @bpoole16, is intended to allow the user to sort a given list of entities alphabetically. This applies to actions, triggers, rules, packages, and apis.

By default, entities are listed in order from most to least recently updated:

$ wsk action list
actions
/guest/packageB/A                  private nodejs:6
/guest/C                                  private nodejs:6
/guest/A                                  private nodejs:6
/guest/packageA/B                  private nodejs:6
/guest/packageA/A                  private nodejs:6
/guest/B                                  private nodejs:6

To see the list of entities sorted alphabetically, use the flag --name-sort or -n:

$ wsk action list --name-sort
actions
/guest/A                                  private nodejs:6
/guest/B                                  private nodejs:6
/guest/C                                  private nodejs:6
/guest/packageA/A                  private nodejs:6
/guest/packageA/B                  private nodejs:6
/guest/packageB/A                  private nodejs:6

The entities are sorted by namespace first, then package name (with the default package actions at the top), and finally by entity name.

Side effects of this PR

We centralized the printing functions within commands/util.go
We created two new interfaces:

Printables: structures that are printed in lists on a regular basis.
Sortables: structures that are meant to be sorted.

Potential upgrades from this branch:

Currently, activations are not sorted alphabetically, only by their start time, and therefore --name-sort is not applicable to activations; however, there may be another way of sorting activations which would be beneficial. The ability to sort activations is set up, one only needs to set the function Compare() in whisk/activation.go and make a custom flag to activate the sorting for it to be implemented.
Add a flag to sort alphabetically by Action name -> Base path -> Rel path -> Verb for APIs

rabbah · 2017-06-01T19:51:53Z

Thanks for picking this up. FYI you might want to look at this PR which seems abandoned #1729 (it has some refinements that I think we'd like to have plus a test).

rabbah · 2017-06-01T19:52:51Z

tools/cli/go-whisk-cli/commands/action.go

@@ -310,7 +311,7 @@ var actionListCmd = &cobra.Command{
        if actions, _, err = client.Actions.List(qualifiedName.entityName, options); err != nil {
            return actionListError(qualifiedName.entityName, options, err)
        }
-
+        


I suggest using a prehook that runs our scan code - this will save you from failed travis builds: https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines

mrutkows · 2017-06-02T15:16:15Z

@underwoodb-sd-ibm Do you have an Apache ICLA signed and can let me know your name to verify? It is part of our project processes/reqs. See https://cwiki.apache.org/confluence/display/OPENWHISK/OpenWhisk+Project+Wiki

Looking at your Github profile, I see this is your first PR... it would be very helpful to make sure you update it to include your name and email (make sure they are public) for not only our project, but others as well.

dubee · 2017-06-07T01:49:20Z

@csantanapr, please add me as a reviewer here as well.

csantanapr · 2017-06-07T02:33:00Z

@dubeejw you can go ahead and do a review, go the "Files changed" tab and do the review.

I can't add you as a reviewer

dubee · 2017-06-07T18:22:59Z

tools/vagrant/README.md

@@ -5,6 +5,7 @@ The following instructions were tested on Mac OS X El Capitan, Ubuntu 14.04.3 LT
 *Requirements*
 - Install [VirtualBox](https://www.virtualbox.org/wiki/Downloads) (tested with version 5.1.22)
 - Install [Vagrant](https://www.vagrantup.com/downloads.html) (tested with version 1.9.5)
+- Install [Cygwin64 with ssh](https://www.cygwin.com) (tested with verstion 2.8.0)


What's this? Should be a separate PR.

It was unintended. I made a new commit retracting this from the Readme file. Thanks!

dubee · 2017-06-08T20:02:29Z

Need tests, and maybe doc update if you added any new flags.

dubee · 2017-06-08T20:37:42Z

tools/cli/go-whisk-cli/commands/action.go

@@ -24,6 +24,7 @@ import (
    "io"
    "strings"

+


Remove extra new line

dubee · 2017-06-08T20:37:55Z

tools/cli/go-whisk-cli/commands/action.go

@@ -310,7 +311,6 @@ var actionListCmd = &cobra.Command{
        if actions, _, err = client.Actions.List(qualifiedName.entityName, options); err != nil {
            return actionListError(qualifiedName.entityName, options, err)
        }
-


Leave new line

dubee · 2017-06-08T20:38:11Z

tools/cli/go-whisk-cli/commands/util.go

@@ -22,6 +22,7 @@ import (
    "fmt"
    "strings"

+


Remove extra new line.

dubee · 2017-06-08T20:38:49Z

tools/cli/go-whisk/whisk/action.go

@@ -22,25 +22,32 @@ import (
    "errors"
    "net/url"
    "../wski18n"
+    "strings"
+


Remove extra new lines.

dubee · 2017-06-08T20:39:17Z

tools/cli/go-whisk/whisk/action.go

    Name        string      `json:"name,omitempty"`
+    Namespace   string      `json:"namespace,omitempty"`


Revert struct to original.

dubee · 2017-06-08T20:39:26Z

tools/cli/go-whisk/whisk/action.go

    Limits      *Limits     `json:"limits,omitempty"`
    Error       string      `json:"error,omitempty"`
    Code        int         `json:"code,omitempty"`
    Publish     *bool       `json:"publish,omitempty"`
 }

+


Remove extra new line.

dubee · 2017-06-08T20:40:12Z

tools/cli/go-whisk/whisk/action.go

+//Defines how actions should be sorted
+//Currently sorts, by default, by Alphabetical order
+func(a Action) Compare(s Sortable) bool{
+  as := s.(Action)


More descriptive variable names would be nice.

dubee · 2017-06-08T20:40:23Z

tools/cli/go-whisk/whisk/package.go

@@ -22,6 +22,8 @@ import (
    "net/url"
    "errors"
    "../wski18n"
+    "strings"
+


Remove extra new line.

dubee · 2017-06-08T20:40:36Z

tools/cli/go-whisk/whisk/trigger.go

@@ -22,6 +22,8 @@ import (
    "errors"
    "net/url"
    "../wski18n"
+    "strings"
+


dubee · 2017-06-13T15:24:04Z

Reading configuration file [/home/travis/build/apache/incubator-openwhisk/tools/build/scanCode.cfg]...
Scanning files starting at [.]...
Scan detected 1 error(s) in 1 file(s):
  [./tools/cli/go-whisk/whisk/util.go]:
      33: line has trailing whitespaces.
Scan detected 1 error(s) in 1 file(s):

dubee · 2017-06-19T15:26:26Z

bin/wskadmin

@@ -1 +0,0 @@
-../tools/admin/wskadmin


Please remove this change. You can use git stash to prevent adding changes that we don't want to be added to a commit.

dubee · 2017-06-19T15:26:37Z

bin/wskdev

@@ -1 +0,0 @@
-../tools/build/redo


Please remove this change.

akrabat

Just some really nit-picky formatting issues.

akrabat · 2017-06-21T13:53:03Z

docs/actions.md


 ```
 wsk action list [PACKAGE NAME]
 ```

+Side Note: Listing works the same way for actions as it does for [packages](./packages.md), [APIs](./apigateway.md), [triggers and rules](./triggers_rules.md). 


Nit pick: For consistency, the docs currently use *Note:* rather than Side Note:

Thanks! Updating now :)

akrabat · 2017-06-21T13:53:33Z

docs/apigateway.md

 ```

+Side Note: APIs will be sorted alphabetically by default, first by Base path, then by Path (relative path), then by Verb. If we need to sort alphabetically by Action name, we can add the `-n` or `--sort-action` flags to do so. 


Again: *Note:* rather than Side Note:

akrabat · 2017-06-21T13:54:03Z

docs/triggers_rules.md

@@ -56,7 +56,7 @@ As an example, create a trigger to send user location updates, and manually fire
  ok: created trigger locationUpdate
  ```

-2. Check that you created the trigger by listing the set of triggers.
+2. Check that you created the trigger by listing the set of triggers. (Side note: triggers and rules will be listed alphabetically when using the `list` command.)


Side note: => Note:

Though, really, this note isn't needed really here as it's not relevant to the tutorial step.

akrabat · 2017-06-21T13:55:55Z

tools/vagrant/README.md

@@ -5,7 +5,7 @@ The following instructions were tested on Mac OS X El Capitan, Ubuntu 14.04.3 LT
 *Requirements*
 - Install [VirtualBox](https://www.virtualbox.org/wiki/Downloads) (tested with version 5.1.22)
 - Install [Vagrant](https://www.vagrantup.com/downloads.html) (tested with version 1.9.5)
-


None of the changes in this file are needed, though I don't suppose tidying up whitespace hurts.

akrabat · 2017-06-21T13:59:48Z

tools/cli/go-whisk-cli/wski18n/resources/en_US.all.json

+  },
+  {
+    "id": "sort api list by action name first followed by base-path/rel-path/verb",
+    "translation": "sort api list by action name first followed by base-path/rel-path/verb."


Capitalise API.

akrabat · 2017-06-21T14:41:34Z

tools/cli/go-whisk-cli/commands/util.go

    return err == nil
 }

 var boldString = color.New(color.Bold).SprintFunc()

+type SortCmds []whisk.Sortable
+//Uses Go builtin sort to sort commands based on their compare methods


Add a space between the comment marker (//) and the text.

akrabat · 2017-06-21T14:42:12Z

tools/cli/go-whisk-cli/commands/util.go

@@ -298,41 +342,17 @@ func printSummary(collection interface{}) {
    case *whisk.Activation:
    }
 }
+//Used to print Action, Tigger, Package, and Rule lists


Add a space between the comment marker (//) and the text.

akrabat · 2017-06-21T14:44:09Z

tests/src/test/scala/system/basic/WskBasicTests.scala

+        }
+
+        val original = wsk.pkg.list().stdout
+        //Create list with action names in correct order


Add a space between the comment marker (//) and the text throughout the file.

dubee · 2017-06-22T17:01:35Z

docs/packages.md

+  /whisk.system/alarms													 shared
+  /whisk.system/cloudant   												 shared
+  /whisk.system/github 													 shared
+  /whisk.system/pushnotifications										 shared


Shared is not aligned properly in the doc when viewing it for pushnotifications and samples.

dubee · 2017-06-22T17:01:49Z

tests/src/test/scala/apigw/healthtests/ApiGwEndToEndTests.scala

+                (action, name) => action.create(name, artifact = Some(file), expectedExitCode = SUCCESS_EXIT, web = Some("true"))
+            }
+            //Create apiexperimentals
+            println("Create api-experimental: Base Path " + base2)


dubee · 2017-06-22T17:01:54Z

tests/src/test/scala/apigw/healthtests/ApiGwEndToEndTests.scala

+              operation = Some("get"),
+              action = Some(actionName2)
+            )
+            println("Create api-experimental: Base Path " + base1)


dubee · 2017-06-22T17:01:59Z

tests/src/test/scala/apigw/healthtests/ApiGwEndToEndTests.scala

+              operation = Some("delete"),
+              action = Some(actionName1)
+            )
+            println("Create api-experimental: Base Path " + base3)


dubee · 2017-06-22T17:02:09Z

tests/src/test/scala/apigw/healthtests/ApiGwEndToEndTests.scala

+                (action, name) => action.create(name, artifact = Some(file), expectedExitCode = SUCCESS_EXIT, web = Some("true"))
+            }
+            //Create api-experimentals
+            println("Create api-experimental: Base Path " + base2)


dubee · 2017-06-22T17:04:13Z

tools/cli/go-whisk-cli/commands/api.go

@@ -299,7 +299,7 @@ var apiDeleteCmd = &cobra.Command{
        if err != nil {
            whisk.Debug(whisk.DbgError, "client.Apis.Delete(%#v, %#v) error: %s\n", apiDeleteReq, apiDeleteReqOptions, err)
            errMsg := wski18n.T("Unable to delete API: {{.err}}", map[string]interface{}{"err": err})
-            whiskErr := whisk.MakeWskError(errors.New(errMsg), whisk.EXITCODE_ERR_GENERAL,
+            whiskErr := whisk.MakeWskErrorFromWskError(errors.New(errMsg), err, whisk.EXITCODE_ERR_GENERAL,


Is this your change or do we need to restore the original?

dubee · 2017-06-22T17:04:35Z

tools/cli/go-whisk-cli/commands/api.go

            for i:=0; i<len(retApiArray.Apis); i++ {
-                printFilteredListRow(retApiArray.Apis[i].ApiValue, (*whisk.ApiOptions)(apiGetReqOptions), maxActionNameSize, maxApiNameSize)
+              sortFilteredRow = append(sortFilteredRow, printFilteredListRow(retApiArray.Apis[i].ApiValue, (*whisk.ApiOptions)(apiGetReqOptions), maxActionNameSize, maxApiNameSize,flagType)...)


Indentation is off.

dubee · 2017-06-22T17:06:24Z

tools/cli/go-whisk/whisk/api.go

+
+  // Check for flag to build proper comparison strings
+  switch api.Flag {
+  case "a":


Make the a character a constant and use the const instead.

dubee · 2017-06-22T17:07:01Z

tools/cli/go-whisk/whisk/trigger.go

+
+    return fmt.Sprintf("%-70s %s\n", fmt.Sprintf("/%s/%s", trigger.Namespace,
+        trigger.Name), publishState)
+


Delete new line here.

dubee · 2017-06-22T17:07:15Z

tools/cli/go-whisk-cli/commands/api.go

-
+        //Checks for any sort flags being passed
+        if flags.api.sortAction {
+          flagType = "a"


Use named constant instead.

dubee · 2017-06-23T19:29:28Z

PG2 1732.

dubee · 2017-06-23T21:27:56Z

PG approved.

underwoodb-sd-ibm · 2017-08-09T17:16:09Z

Update on latest design: the description of functionality for this PR has been updated in the top comment, but in short: per discussions with @mdeuser, @dubeejw, and @csantanapr, sorting by latest updated time has been made default again, and sorting alphabetically is now done with the flag --name-sort or -n. On top of working on the review issues raised by @rabbah, I recently removed some unnecessary variable passing and cleaned up a few comments.

rabbah

small change requested - to move tests, add retries.

rabbah · 2017-08-09T17:35:56Z

tests/src/test/scala/system/basic/WskBasicTests.scala

@@ -210,6 +210,35 @@ class WskBasicTests
        stderr should include regex (s"""Unable to get package '$name': The requested resource does not exist. \\(code \\d+\\)""")
    }

+    it should "return a list of alphabetized packages" in withAssetCleaner(wskprops) {


this test belongs in wsk basic uses tests, not the system package.

rabbah · 2017-08-09T17:36:35Z

tests/src/test/scala/system/basic/WskBasicTests.scala

@@ -210,6 +210,35 @@ class WskBasicTests
        stderr should include regex (s"""Unable to get package '$name': The requested resource does not exist. \\(code \\d+\\)""")
    }

+    it should "return a list of alphabetized packages" in withAssetCleaner(wskprops) {


same for subsequent tests - generally the system package is for health checks.

rabbah · 2017-08-09T17:37:20Z

tests/src/test/scala/system/basic/WskBasicTests.scala

+                        pkg.create(name)
+                }
+            }
+            val original = wsk.pkg.list(nameSort = Some(true)).stdout


it may be prudent to wrap these checks with a retry (here and elsewhere) since a list operation may take some time to converge.

dubee · 2017-08-09T17:34:32Z

docs/actions.md

+
+**Note**: The printed list is sorted alphabetically after it is received from the server. Other list flags such as `--limit` and `--skip` will be applied to the block of actions before they are received for sorting. To list actions in order by creation time, use the flag `--time`.
+
+As you write more actions, this list gets longer and it can be helpful to group related actions into [packages](./packages.md). To filter your list of actions to just the those within a specific package, you can use:


Drop the from the those.

dubee · 2017-08-09T17:35:42Z

docs/actions.md

 ```

-As you write more actions, this list gets longer and it can be helpful to group related actions into [packages](./packages.md). To filter your list of actions to just the those within a specific pacakge, you can use:
+Here, we see actions listed in order from most to least recently updated. For easier browsing, you can use the flag `--name-sort` or `-n` to sort a list alphabetically:


Would change sort a list alphabetically to sort the list alphabetically

dubee · 2017-08-09T17:41:46Z

tests/src/test/scala/system/basic/WskBasicTests.scala

@@ -459,6 +480,27 @@ class WskBasicTests
        wsk.action.get(name).stdout should not include (""""code"""")
    }

+    it should "return a list of alphabetized actions" in withAssetCleaner(wskprops) {


Need a test that ensures a packaged action is in the anticipated list order.

dubee · 2017-08-09T17:43:56Z

tools/cli/go-whisk-cli/commands/namespace.go

@@ -55,7 +55,7 @@ var namespaceListCmd = &cobra.Command{
            werr := whisk.MakeWskErrorFromWskError(errors.New(errStr), err, whisk.EXITCODE_ERR_NETWORK, whisk.DISPLAY_MSG, whisk.NO_DISPLAY_USAGE)
            return werr
        }
-        printList(namespaces)
+        printList(namespaces, false) // `-t` flag appliest to `namespace get`, not list, so must pass value false for printList here


Typo applies.

dubee · 2017-08-09T17:56:27Z

tools/cli/go-whisk/whisk/namespace.go

+func(namespace Namespace) ToHeaderString() string {
+    var boldString = color.New(color.Bold).SprintFunc()
+
+    return fmt.Sprintf("%s\n", boldString("namespaces"))


This package should not know how the consumers of it operate. Here you are making the header bold to satisfy the consumer in function printCommandsList().

The above applies to all the ToHeaderString() methods.

underwoodb-sd-ibm · 2017-08-10T12:26:44Z

@dubeejw - please confirm that the issue you raised with the ToHeaderString() functions have been addressed properly? Thanks

- Created interfaces `Printables` and `Sortables` - Made Actions, Triggers, Packages, Rules, APIs into Printables and Sortables - Made Activations into Printables and Sortables, Sort currently undefined - Made alphabetic sorting default, sort by last update time with --time flag - Changed sorting default back to last update time, --sort flag for alphabetical sorting - Updated flag name to "--name-sort"/"-n" - Made tests in ApiGwTests & WskBasicUsageTests - Update to WskRuleTests - Updated Docs - Fixed rule status printing for `wsk list` and `wsk namespace get`

underwoodb-sd-ibm · 2017-08-10T15:39:50Z

Update: added code to allow wsk list and wsk namespace get to properly print rule status. Inadvertently closes #2598.

underwoodb-sd-ibm · 2017-08-10T15:40:06Z

PG1 1939 - Passed

jessealva · 2017-08-10T19:00:08Z

Looks like this also resolves #2598 Just looked at the change history after talking to Brandon and can verify it will fix that issue as well.

rabbah · 2017-08-11T01:44:24Z

tests/src/test/scala/whisk/core/cli/test/WskBasicUsageTests.scala

+                val regex = s"${actionName}[1-3]".r
+                // Retrieve action names into list as found in original
+                val list  = (regex.findAllMatchIn(original)).toList
+                scalaSorted.toString shouldEqual list.toString


i'm guessing .toString here isn't necessary.

is it?
applies in multiple places.

- Created interfaces `Printables` and `Sortables` - Made Actions, Triggers, Packages, Rules, APIs into Printables and Sortables - Made Activations into Printables and Sortables, Sort currently undefined - Made alphabetic sorting default, sort by last update time with --time flag - Changed sorting default back to last update time, --sort flag for alphabetical sorting - Updated flag name to "--name-sort"/"-n" - Updated Docs - Fixed rule status printing for `wsk list` and `wsk namespace get`

rabbah added cli enhancement labels Jun 1, 2017

rabbah reviewed Jun 1, 2017

View reviewed changes

dubee requested changes Jun 7, 2017

View reviewed changes

dubee requested changes Jun 8, 2017

View reviewed changes

underwoodb-sd-ibm force-pushed the alphabetize branch from 7b46a68 to df5ee80 Compare June 13, 2017 15:15

rabbah mentioned this pull request Jun 13, 2017

Sort packages, actions, triggers, rules by name alphabetically. #1729

Closed

underwoodb-sd-ibm closed this Jun 15, 2017

underwoodb-sd-ibm reopened this Jun 15, 2017

dubee requested changes Jun 19, 2017

View reviewed changes

akrabat reviewed Jun 21, 2017

View reviewed changes

underwoodb-sd-ibm force-pushed the alphabetize branch from 528a38c to 751f458 Compare June 22, 2017 16:14

dubee requested changes Jun 22, 2017

View reviewed changes

underwoodb-sd-ibm force-pushed the alphabetize branch 2 times, most recently from 76c9018 to c681e6f Compare June 22, 2017 19:21

underwoodb-sd-ibm closed this Jun 22, 2017

underwoodb-sd-ibm reopened this Jun 22, 2017

underwoodb-sd-ibm force-pushed the alphabetize branch 3 times, most recently from 6aa6f52 to 392d495 Compare June 23, 2017 18:47

underwoodb-sd-ibm changed the title ~~(WIP) Alphabetize~~ (Review) Alphabetize Jun 24, 2017

underwoodb-sd-ibm force-pushed the alphabetize branch from 392d495 to 1aab93e Compare June 26, 2017 12:12

underwoodb-sd-ibm force-pushed the alphabetize branch 4 times, most recently from 1df8acd to 1209db6 Compare August 9, 2017 16:43

rabbah requested changes Aug 9, 2017

View reviewed changes

dubee requested changes Aug 9, 2017

View reviewed changes

underwoodb-sd-ibm force-pushed the alphabetize branch 2 times, most recently from ec4c19e to 702db53 Compare August 9, 2017 20:10

underwoodb-sd-ibm force-pushed the alphabetize branch from 702db53 to 84149f4 Compare August 10, 2017 13:36

dubee approved these changes Aug 10, 2017

View reviewed changes

rabbah reviewed Aug 11, 2017

View reviewed changes

rabbah approved these changes Aug 11, 2017

View reviewed changes

rabbah merged commit fe42018 into apache:master Aug 11, 2017

		Name string `json:"name,omitempty"`
		Namespace string `json:"namespace,omitempty"`

		```

		Side Note: APIs will be sorted alphabetically by default, first by Base path, then by Path (relative path), then by Verb. If we need to sort alphabetically by Action name, we can add the `-n` or `--sort-action` flags to do so.


		return fmt.Sprintf("%-70s %s\n", fmt.Sprintf("/%s/%s", trigger.Namespace,
		trigger.Name), publishState)


		Note: The printed list is sorted alphabetically after it is received from the server. Other list flags such as `--limit` and `--skip` will be applied to the block of actions before they are received for sorting. To list actions in order by creation time, use the flag `--time`.

		As you write more actions, this list gets longer and it can be helpful to group related actions into [packages](./packages.md). To filter your list of actions to just the those within a specific package, you can use:

		@@ -1 +0,0 @@
		../tools/admin/wskadmin

		@@ -1 +0,0 @@
		../tools/build/redo

Alphabetize listings in CLI #2326

Alphabetize listings in CLI #2326

Conversation

underwoodb-sd-ibm commented Jun 1, 2017 • edited Loading

rabbah commented Jun 1, 2017

Choose a reason for hiding this comment

mrutkows commented Jun 2, 2017 • edited Loading

dubee commented Jun 7, 2017

csantanapr commented Jun 7, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dubee commented Jun 8, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dubee commented Jun 13, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

akrabat left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dubee commented Jun 23, 2017 • edited Loading

dubee commented Jun 23, 2017

underwoodb-sd-ibm commented Aug 9, 2017

rabbah left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

underwoodb-sd-ibm commented Aug 10, 2017

underwoodb-sd-ibm commented Aug 10, 2017

underwoodb-sd-ibm commented Aug 10, 2017

jessealva commented Aug 10, 2017

rabbah Aug 11, 2017 • edited Loading

Choose a reason for hiding this comment

underwoodb-sd-ibm commented Jun 1, 2017 •

edited

Loading

mrutkows commented Jun 2, 2017 •

edited

Loading

akrabat left a comment •

edited

Loading

dubee commented Jun 23, 2017 •

edited

Loading

rabbah left a comment •

edited

Loading

rabbah Aug 11, 2017 •

edited

Loading