Add ansible deploy options

[BillZong]

Add docker image pull (or not) options to kafka and zookeeper deployment.

Description

If the docker tagged(especially the "latest") image is already in environment machine, adding this option could speed up deployment.

Related issue and scope

• I opened an issue to propose and discuss this change (#????)

My changes affect the following components

• API
• Controller
• Message Bus (e.g., Kafka)
• Loadbalancer
• Invoker
• Intrinsic actions (e.g., sequences, conductors)
• Data stores (e.g., CouchDB)
• Tests
• Deployment
• CLI
• General tooling
• Documentation

Types of changes

• Bug fix (generally a non-breaking change which closes an issue).
• Enhancement or new feature (adds new functionality).
• Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

• I signed an Apache CLA.
• I reviewed the style guides and followed the recommendations (Travis CI will check :).
• I added tests to cover my changes.
• My changes require further changes to the documentation.
• I updated the documentation where necessary.

[codecov-io]

Codecov Report

Merging #4619 into master will decrease coverage by 5.76%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4619      +/-   ##
==========================================
- Coverage   84.54%   78.77%   -5.77%     
==========================================
  Files         183      183              
  Lines        8308     8308              
  Branches      571      571              
==========================================
- Hits         7024     6545     -479     
- Misses       1284     1763     +479

Impacted Files	Coverage Δ
...core/database/cosmosdb/RxObservableImplicits.scala	0% <0%> (-100%)	⬇️
...ore/database/cosmosdb/cache/CacheInvalidator.scala	0% <0%> (-100%)	⬇️
...core/database/cosmosdb/CosmosDBArtifactStore.scala	0% <0%> (-95.89%)	⬇️
...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala	0% <0%> (-94.74%)	⬇️
...sk/core/database/cosmosdb/CosmosDBViewMapper.scala	0% <0%> (-92.6%)	⬇️
...e/database/cosmosdb/cache/ChangeFeedListener.scala	0% <0%> (-86.67%)	⬇️
...e/database/cosmosdb/cache/KafkaEventProducer.scala	0% <0%> (-76.48%)	⬇️
...whisk/core/database/cosmosdb/CosmosDBSupport.scala	0% <0%> (-74.08%)	⬇️
...a/org/apache/openwhisk/common/ExecutorCloser.scala	0% <0%> (-66.67%)	⬇️
...abase/cosmosdb/CosmosDBArtifactStoreProvider.scala	4% <0%> (-52%)	⬇️
... and 10 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94f7b14...4663969. Read the comment docs.

[rabbah]

LGTM - not sure why there was a separate pull task.

[BillZong]

Looks like intuitive coding the same as manual operation.

[csantanapr]

I think all 3rd images are a separate task to have retries with delays and be configurable

I think I remember the docker will try once to pull and first error doesn’t retry

[rabbah]

I thought so too but then noticed Kafka didn't have the same pull task - so I dismissed that explanation.

[BillZong]

The retry here is meaningless, since errors happened here are fatal for deployment.
e.g. image name/tag spelled wrong, wrong password for docker repo, network timeout, etc.

All we should do is to fix them and re-deploy, instead of retrying.

[BillZong]

@rabbah
Sorry for my bold clicked. ORZ
Not very familiar with the Github buttons.

[rabbah]

Thanks for the contribution.