Add cors headers to components' server admin routes #5351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
October 12, 2022 18:01
bdoyle0182
commented
Nov 8, 2022
core/invoker/src/main/scala/org/apache/openwhisk/core/invoker/FPCInvokerReactive.scala
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #5351 +/- ##
==========================================
- Coverage 81.26% 76.35% -4.92%
==========================================
Files 240 240
Lines 14393 14407 +14
Branches 603 618 +15
==========================================
- Hits 11697 11000 -697
- Misses 2696 3407 +711
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
style95
reviewed
Nov 9, 2022
| @@ -78,6 +76,7 @@ case class DeletionContainer(deletionMessage: ContainerDeletionMessage) | |||
| case object Remove | |||
| case class Keep(timeout: FiniteDuration) | |||
| case class PrewarmContainer(maxConcurrent: Int) | |||
| case object GetState | |||
There was a problem hiding this comment.
Is there any reason we should define another GetState here?
There was a problem hiding this comment.
I see what happened now, I had this in progress for awhile and had a bad merge somewhere with your recent commits. Should all be cleaned up now.
...rc/main/scala/org/apache/openwhisk/core/containerpool/v2/FunctionPullingContainerProxy.scala
Outdated
Show resolved
Hide resolved
|
Not at the moment don't have bandwidth to do any ui work, but maybe down the road |
style95
approved these changes
Nov 10, 2022
msciabarra
pushed a commit
to nuvolaris/openwhisk
that referenced
this pull request
Nov 23, 2022
* add container pool state route to invoker * scalafmt * wip * add cors headers to components server admin routes * scalafmt * fix bad merge Co-authored-by: Brendan Doyle <brendand@qualtrics.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr adds cors headers to the server admin routes of each component plus the options route which is needed for pre-flight requests from browsers when auth is included in the request. The reason for this is to lay the ground work for future ui work for an admin portal.
Related issue and scope
My changes affect the following components
Types of changes
Checklist: