upgrade kafka client library to 2.8.2 #5400
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5400 +/- ##
==========================================
- Coverage 76.69% 76.59% -0.10%
==========================================
Files 240 240
Lines 14596 14596
Branches 671 671
==========================================
- Hits 11194 11180 -14
- Misses 3402 3416 +14 see 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bdoyle0182
force-pushed
the
upgrade-kafka-client
branch
6 times, most recently
from
dd2c827
to
9af29cd
Compare
bdoyle0182
force-pushed
the
upgrade-kafka-client
branch
from
9af29cd
to
b9d1c12
Compare
bdoyle0182
force-pushed
the
upgrade-kafka-client
branch
from
08f737d
to
5dc416a
Compare
bdoyle0182
changed the title
| @@ -45,9 +45,9 @@ dependencies { | |||
|
|
|||
| testImplementation "junit:junit:4.11" | |||
| testImplementation "org.scalatest:scalatest_${gradle.scala.depVersion}:3.0.8" | |||
| testImplementation "io.github.embeddedkafka:embedded-kafka_${gradle.scala.depVersion}:2.4.0" | |||
| testImplementation "io.github.embeddedkafka:embedded-kafka_${gradle.scala.depVersion}:2.8.1" | |||
There was a problem hiding this comment.
embedded kafka for the tests doesn't have a release for 2.8.2, but works against any 2.8.x version of the kafka client.
| override val sleepAfterProduce: FiniteDuration = 10.seconds | ||
| override protected val topicCreationTimeout = 60.seconds | ||
| override protected val topicCreationTimeout = 120.seconds |
There was a problem hiding this comment.
I am just curious if this is to apply different timeouts for topic creation and publishing timeout or if there was any case that topic creation takes more than 60s.
There was a problem hiding this comment.
I've reverted the timeout changes I think it was just leftover from me trying to get the tests to work, but still think the topic creation needs to be the same timeout as produce timeout rather than the default of the test library which is 10s.
also I've added the cve's to the description. for bug fixes it would be hard to cover here rather than just pointing to the kafka release notes between 2.4.0 and 2.8.2.
|
Nice! 🎉 |
* upgrade kafka client library * attempt build upgrading embedded kafka * attempt to fix standalone server startup test * bump to kafka client to latest patch * revert kafka test timeout config change --------- Co-authored-by: Brendan Doyle <brendand@qualtrics.com> (cherry picked from commit 6bc559d)
Description
handles cve's and some critical bug fixes. This can be updated safely without updating underlying kafka of the ansible which is still set to 2.7.0. have tested a build myself that things still work but still need to see if all tests pass here.
cve's fixed:
cve's from transitive dependencies:
Related issue and scope
My changes affect the following components
Types of changes
Checklist: