ORC-857: Add OuterTypeFilename/UpperEll/ArrayTypeStyle checkstyle rules.

* What changes were proposed in this pull request? This PR aims to add Java checkstyle rules OuterTypeFilename, UpperEll, and ArrayTypeStyle. * Why are the changes needed? To improve code quality. * How was this patch tested? Pass the GHA. Closes #759. Signed-off-by: William Hyun <william@apache.org> (cherry picked from commit b34da1b) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
apache · Jul 24, 2021 · 8189157 · 8189157
1 parent e1f06d3
commit 8189157
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/java/core/src/java/org/apache/orc/impl/RunLengthIntegerWriterV2.java b/java/core/src/java/org/apache/orc/impl/RunLengthIntegerWriterV2.java
@@ -124,7 +124,7 @@ public enum EncodingType {
 
   static final int MAX_SCOPE = 512;
   static final int MIN_REPEAT = 3;
-  static final long BASE_VALUE_LIMIT = 1l << 56;
+  static final long BASE_VALUE_LIMIT = 1L << 56;
   private static final int MAX_SHORT_REPEAT_LENGTH = 10;
   private long prevDelta = 0;
   private int fixedRunLength = 0;

diff --git a/java/core/src/java/org/apache/orc/util/BloomFilterIO.java b/java/core/src/java/org/apache/orc/util/BloomFilterIO.java
@@ -78,7 +78,7 @@ public static BloomFilter deserialize(OrcProto.Stream.Kind kind,
     int numFuncs = bloomFilter.getNumHashFunctions();
     switch (kind) {
       case BLOOM_FILTER: {
-        long values[] = new long[bloomFilter.getBitsetCount()];
+        long[] values = new long[bloomFilter.getBitsetCount()];
         for (int i = 0; i < values.length; ++i) {
           values[i] = bloomFilter.getBitset(i);
         }

diff --git a/java/pom.xml b/java/pom.xml
@@ -286,7 +286,10 @@
                   <property name="message" value="No trailing white space allowed."/>
                 </module>
                 <module name="TreeWalker">
+                  <module name="OuterTypeFilename"/>
                   <module name="UnusedImports"/>
+                  <module name="UpperEll"/>
+                  <module name="ArrayTypeStyle"/>
                 </module>
               </module>
             </checkstyleRules>