ORC-857: Add OuterTypeFilename/UpperEll/ArrayTypeStyle checkstyle rules. #759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @dongjoon-hyun I'll try to find more useful rules. |
dongjoon-hyun
approved these changes
Jul 23, 2021
There was a problem hiding this comment.
+1, LGTM. Thank you for making a PR swiftly, @williamhyun !
|
Thank you, I will merge this and make a new PR for the next rules. |
|
Sure! Go ahead. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jul 24, 2021
* What changes were proposed in this pull request? This PR aims to add Java checkstyle rules OuterTypeFilename, UpperEll, and ArrayTypeStyle. * Why are the changes needed? To improve code quality. * How was this patch tested? Pass the GHA. Closes #759. Signed-off-by: William Hyun <william@apache.org> (cherry picked from commit b34da1b) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
|
I cherry-picked this to branch-1.7, too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to add Java checkstyle rules OuterTypeFilename, UpperEll, and ArrayTypeStyle.
Why are the changes needed?
To improve code quality.
How was this patch tested?
Pass the GHA.