ORC-187: Simplify BitFieldReader to only support single bits #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t3rmin4t0r
reviewed
Nov 3, 2017
| current = input.next(); | ||
| bitsLeft = (int) (8 - (totalBits % 8)); | ||
| final long bitsToSkip = (totalBits - availableBits); | ||
| input.skip(Math.min(1, bitsToSkip / 8)); |
There was a problem hiding this comment.
Looks a bit odd - the min(1) might be a problem if
availableBits = 0 and items=3, it will end up skip(1) where it should really be doing skip(0).
|
LGTM - +1 |
|
Since this is removing the old functionality, you should remove the old constructor that takes the bitWidth. With this change, someone who passed in a non-one width would be surprised with the result. |
rajeshbalamohan
changed the title
|
@asfgit merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.