Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ORC-318. Change KeyProvider API to separate createLocalKey #227

Closed
wants to merge 1 commit into from
Closed

ORC-318. Change KeyProvider API to separate createLocalKey #227

wants to merge 1 commit into from

Conversation

omalley
Copy link
Contributor

@omalley omalley commented Mar 7, 2018

Separate createLocalKey from decryptLocalKey in HadoopShims.KeyProvider.

It also:

  • changes HadoopShims.KeyMetadata from an interface to a concrete class
  • creates a NullKeyProvider for Hadoop versions < 2.7

@omalley omalley force-pushed the orc-318 branch 2 times, most recently from c48876e to 24912f7 Compare March 26, 2018 16:38
omalley added a commit to omalley/orc that referenced this pull request Mar 26, 2018
@omalley
ORC-318. Change KeyProvider API to separate createLocalKey from decry…
24912f7 
…ptLocalKey.

Fixes apache#227

Signed-off-by: Owen O'Malley <omalley@apache.org>
@omalley
Copy link
Contributor Author

omalley commented Mar 26, 2018 •
edited
Loading

Ok, I significantly updated this patch.

  • I added tests for both the InMemoryKeyProvider and the Hadoop-based KeyProvider.
  • I allowed the user to pass in a Random implementation for the KeyProvider. That allows me to control the random for tests.
  • I added a lot of documentation about what I was doing and why.
  • I changed the InMemoryKeyProvider to use AES/CBC/NoPadding to encrypt and decrypt the local keys. Thus like the AWS KMS, the operations for encryption and decryption aren't symmetric.

omalley added a commit to omalley/orc that referenced this pull request Mar 26, 2018
@omalley
ORC-318. Change KeyProvider API to separate createLocalKey from decry…
1e4321d 
…ptLocalKey.

Fixes apache#227

Signed-off-by: Owen O'Malley <omalley@apache.org>
@omalley
ORC-318. Change KeyProvider API to separate createLocalKey from decry…
6a3c60d 
…ptLocalKey.

Fixes apache#227

Signed-off-by: Owen O'Malley <omalley@apache.org>
@asfgit asfgit closed this in 6453f16 Apr 12, 2018
asfgit pushed a commit that referenced this pull request Apr 12, 2018
@omalley
ORC-318. Change KeyProvider API to separate createLocalKey from decry…
98fdba9 
…ptLocalKey.

Fixes #227

Signed-off-by: Owen O'Malley <omalley@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@omalley