Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORC-531. Refactor schema evolution including removing the float conversions. #411

Merged
merged 1 commit into from
Jul 15, 2019

Conversation

omalley
Copy link
Contributor

@omalley omalley commented Jul 12, 2019

This PR removes about 700 lines from the schema evolution code:

  • Removes most of the float conversions, which aren't needed now.
  • Removes the duplicate reference to the underlying TreeReader in each subclass.
  • Creates a new double->float conversion that casts it to a float instead of using strings.
  • The test case float->double had to loosen the delta on the comparison since we don't get the implicit truncation from going through stringification.
  • Moves the file names for TestSchemaEvolution to use that as the filename prefix on the written orc files.

@omalley omalley requested a review from prasanthj July 12, 2019 18:00
…rsions.

Fixes apache#411

Signed-off-by: Owen O'Malley <omalley@apache.org>
@omalley omalley merged commit ab6f06e into apache:master Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant