ORC-952: Add since tag to org.apache.orc.RecordReader interface
#865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
changed the title
since tag to org.apache.orc.RecordReader interface
williamhyun
reviewed
Aug 15, 2021
| */ | ||
| float getProgress() throws IOException; | ||
|
|
||
| /** | ||
| * Release the resources associated with the given reader. | ||
| * @throws java.io.IOException | ||
| * @since 1.1.0 | ||
| */ | ||
| @Override | ||
| void close() throws IOException; |
There was a problem hiding this comment.
Could you add the tag to seekToRow?
|
Thank you! |
dongjoon-hyun
added a commit
that referenced
this pull request
Aug 16, 2021
…865) ### What changes were proposed in this pull request? This PR aims to add `since` tag to `org.apache.orc.Reader` interface. ### Why are the changes needed? To help ORC developers to check the API availability easily by improving code and Javadoc. ### How was this patch tested? Manual (cherry picked from commit daa57f8) Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to add
sincetag toorg.apache.orc.Readerinterface.Why are the changes needed?
To help ORC developers to check the API availability easily by improving code and Javadoc.
How was this patch tested?
Manual