ORC-982: Extract checkstyle to a single file, help newcomers check code style #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
java/checkstyle.xml
Outdated
| "https://checkstyle.org/dtds/configuration_1_2.dtd"> | ||
|
|
||
| <module name="Checker"> | ||
| <module name="FileTabCharacter"> |
There was a problem hiding this comment.
Shall we use two-space indentation?
There was a problem hiding this comment.
My IDE's config for xml indentation defaults to 4 spaces. I'll fix this later.
|
cc @williamhyun |
java/checkstyle.xml
Outdated
| limitations under the License. | ||
| --> | ||
| <!DOCTYPE module PUBLIC | ||
| "-//Checkstyle//DTD Checkstyle Configuration 1.2//EN" |
There was a problem hiding this comment.
ditto. This needs 4 spaces instead of 8 spaces.
dongjoon-hyun
approved these changes
Sep 3, 2021
|
Thank you very much @dongjoon-hyun, thank to review and fix format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Extract checkstyle to a single file.
Added tips to coding.md.
Why are the changes needed?
CheckStyle-IDEA plugin is very simple to load this checkstyle.xml. This way you get checkstyle errors/warnings already when you are coding.
How was this patch tested?
Pass the CIs.