Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimizing] improve and refine the usage scope of interfaces and classes. #428

Open
5 tasks done
psxjoy opened this issue Aug 27, 2024 · 2 comments
Open
5 tasks done
Assignees

Comments

@psxjoy
Copy link
Contributor

psxjoy commented Aug 27, 2024

Description

Some controller classes in the project currently use implementation classes of interfaces for dependency injection. While this method allows the project to function properly, it does not adhere to modern code layering practices and may lead to difficulties with future scalability and maintenance.

Optimize

I believe this section of the code should be refactored to clearly separate interfaces from their implementation classes, ensuring standardized usage.

Benfits

The refactored code offers several benefits:

  1. It aligns with common project layering best practices;
  2. It facilitates easier code reuse in the future.

Task

@psxjoy
Copy link
Contributor Author

psxjoy commented Aug 27, 2024

If it's possible, please assign this issue to me. I'm willing to take it on and resolve it.
@wtt40122 @goodjava

@psxjoy
Copy link
Contributor Author

psxjoy commented Sep 10, 2024

Thanks to everyone for your code reviews and support during this process. I believe all the optimization tasks for this issue have been successfully completed. Feel free to close the issue whenever you're ready. @wodiwudi @gaoxh @sadadw1

感谢大家的 code review 和过程中的帮助。我认为涉及的优化任务已经全部完成了。你们可以随时关闭这个issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant