Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimizing] Improve code layering of ozhera-prometheus-agent module #434

Closed
psxjoy opened this issue Sep 2, 2024 · 0 comments · Fixed by #437
Closed

[Optimizing] Improve code layering of ozhera-prometheus-agent module #434

psxjoy opened this issue Sep 2, 2024 · 0 comments · Fixed by #437

Comments

@psxjoy
Copy link
Contributor

psxjoy commented Sep 2, 2024

Description

Some controller classes in the project currently use implementation classes of interfaces for dependency injection. While this method allows the project to function properly, it does not adhere to modern code layering practices and may lead to difficulties with future scalability and maintenance.

Optimize

Separate interfaces from their implementation classes, ensuring standardized usage.

Linked Module:

ozhera-prometheus-agent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant