New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-4137. Turn on the verbose mode of safe mode check on testlib #1343
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This breaks upgrade
acceptance test, as old version (0.5.0) tries to use new flag. Please introduce a new variable in hadoop-ozone/dist/src/main/compose/upgrade/versions/ozone-0.5.0.sh
and hadoop-ozone/dist/src/main/compose/upgrade/versions/ozone-0.6.0.sh
, eg.:
export OZONE_SAFEMODE_STATUS_COMMAND='ozone scmcli safemode status'
and
export OZONE_SAFEMODE_STATUS_COMMAND='ozone admin safemode status --verbose'
respectively, then use the new variable in testlib.sh
.
25e1c26
to
58c79ea
Compare
@adoroszlai Thanks very much for show me this tip, I think it can help me to pass the acceptance test. |
@maobaolong Thanks for updating the patch. Sorry, I forgot that diff --git hadoop-ozone/dist/src/main/compose/testlib.sh hadoop-ozone/dist/src/main/compose/testlib.sh
index 24a7de3b1..228572fe2 100755
--- hadoop-ozone/dist/src/main/compose/testlib.sh
+++ hadoop-ozone/dist/src/main/compose/testlib.sh
@@ -63,7 +63,7 @@ find_tests(){
## @description wait until safemode exit (or 180 seconds)
wait_for_safemode_exit(){
# version-dependent
- : ${OZONE_ADMIN_COMMAND:=admin}
+ : ${OZONE_SAFEMODE_STATUS_COMMAND:=ozone admin safemode status --verbose}
#Reset the timer
SECONDS=0 |
@adoroszlai Thank you for trigger CI checks for me, I see full green now, 😁. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @maobaolong for the contribution. This should help in debugging intermittent failures due to SCM not coming out of safe mode.
* master: (26 commits) HDDS-4167. Acceptance test logs missing if fails during cluster startup (apache#1366) HDDS-4121. Implement OmMetadataMangerImpl#getExpiredOpenKeys. (apache#1351) HDDS-3867. Extend the chunkinfo tool to display information from all nodes in the pipeline. (apache#1154) HDDS-4077. Incomplete OzoneFileSystem statistics (apache#1329) HDDS-3903. OzoneRpcClient support batch rename keys. (apache#1150) HDDS-4151. Skip the inputstream while offset larger than zero in s3g (apache#1354) HDDS-4147. Add OFS to FileSystem META-INF (apache#1352) HDDS-4137. Turn on the verbose mode of safe mode check on testlib (apache#1343) HDDS-4146. Show the ScmId and ClusterId in the scm web ui. (apache#1350) HDDS-4145. Bump version to 1.1.0-SNAPSHOT on master (apache#1349) HDDS-4109. Tests in TestOzoneFileSystem should use the existing MiniOzoneCluster (apache#1316) HDDS-4149. Implement OzoneFileStatus#toString (apache#1356) HDDS-4153. Increase default timeout in kubernetes tests (apache#1357) HDDS-2411. add a datanode chunk validator fo datanode chunk generator (apache#1312) HDDS-4140. Auto-close /pending pull requests after 21 days of inactivity (apache#1344) HDDS-4152. Archive container logs for kubernetes check (apache#1355) HDDS-4056. Convert OzoneAdmin to pluggable model (apache#1285) HDDS-3972. Add option to limit number of items displaying through ldb tool. (apache#1206) HDDS-4068. Client should not retry same OM on network connection failure (apache#1324) HDDS-4062. Non rack aware pipelines should not be created if multiple racks are alive. (apache#1291) ...
What changes were proposed in this pull request?
Turn on the verbose mode of safe mode check on testlib
What is the link to the Apache JIRA
HDDS-4137
How was this patch tested?
No need