HDDS-4140. Auto-close /pending pull requests after 21 days of inactivity #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix close-pending command
adoroszlai
reviewed
Aug 25, 2020
.github/workflows/close-pending.yaml
Outdated
|
|
||
| on: | ||
| schedule: | ||
| - cron: '*/5 * * * *' |
There was a problem hiding this comment.
I think it would be better to run this workflow once per day instead of every 5 minutes. The list of pending PRs to be closed is filtered only by date (eg. 2020-08-03), not time, so most of the runs would be no-ops.
There was a problem hiding this comment.
Absolutely, I started with one day but changed it to five minutes to show if it works. Changing back.
adoroszlai
approved these changes
Aug 26, 2020
|
Thanks the review @adoroszlai. Let me merge it and 🔥 the 💣 (I am planning to create a filter to review pending + closed and check it sometimes...) |
rakeshadr
pushed a commit
to rakeshadr/hadoop-ozone
that referenced
this pull request
Sep 3, 2020
errose28
added a commit
to errose28/ozone
that referenced
this pull request
Sep 11, 2020
* master: (26 commits) HDDS-4167. Acceptance test logs missing if fails during cluster startup (apache#1366) HDDS-4121. Implement OmMetadataMangerImpl#getExpiredOpenKeys. (apache#1351) HDDS-3867. Extend the chunkinfo tool to display information from all nodes in the pipeline. (apache#1154) HDDS-4077. Incomplete OzoneFileSystem statistics (apache#1329) HDDS-3903. OzoneRpcClient support batch rename keys. (apache#1150) HDDS-4151. Skip the inputstream while offset larger than zero in s3g (apache#1354) HDDS-4147. Add OFS to FileSystem META-INF (apache#1352) HDDS-4137. Turn on the verbose mode of safe mode check on testlib (apache#1343) HDDS-4146. Show the ScmId and ClusterId in the scm web ui. (apache#1350) HDDS-4145. Bump version to 1.1.0-SNAPSHOT on master (apache#1349) HDDS-4109. Tests in TestOzoneFileSystem should use the existing MiniOzoneCluster (apache#1316) HDDS-4149. Implement OzoneFileStatus#toString (apache#1356) HDDS-4153. Increase default timeout in kubernetes tests (apache#1357) HDDS-2411. add a datanode chunk validator fo datanode chunk generator (apache#1312) HDDS-4140. Auto-close /pending pull requests after 21 days of inactivity (apache#1344) HDDS-4152. Archive container logs for kubernetes check (apache#1355) HDDS-4056. Convert OzoneAdmin to pluggable model (apache#1285) HDDS-3972. Add option to limit number of items displaying through ldb tool. (apache#1206) HDDS-4068. Client should not retry same OM on network connection failure (apache#1324) HDDS-4062. Non rack aware pipelines should not be created if multiple racks are alive. (apache#1291) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Earlier we introduced a way to mark the inactive pull requests with "pending" label (with the help of /pending comment).
This pull requests introduce a new scheduled build which closes the "pending" pull requests after 21 days of inactivity.
IMPORTANT: Only the pull requests which are pending on the author will be closed.
We should NEVER close a pull requests which are waiting for the attention of a committer.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4140
How was this patch tested?
on the https://github.com/elek/hadoop-ozone/ fork with this PR: elek#13