New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-4258. Set GDPR to a Security submenu in EN and CN document #1524
Conversation
Thanks @frischHWC for working on this. |
Thanks @cku328 for seeing this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @frischHWC for the comment. It sounds good to me.
I think you can replace the description on the Features
page with this text, because GDPR in Ozone
has been moved to the Security
page.
Thanks @cku328 for quick review, however on CN part, I cannot translate the newly added description of Features and removal of GDPR part. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Thanks @frischHWC for fixing it.
As for the part on CN translation, I think it can be modified in this issue (HDDS-4184).
+1 LGTM. |
GDPR is not a security feature, it is a compliance feature. |
Thanks for @dineshchitlangia comment. |
Thanks @dineshchitlangia for the clarification. Here is my understanding: GDPR itself is a EU regulation. To achieve compliance, Ozone support part of it via security mechanism such as encryption to protect user data privacy and right to be forgotten. From technical point of view, the current implementation can be categorized under the security umbrella. In the future, if we have other part of GDPR(non-security related) implemented in Ozone, we could highlight them separately outside Security. |
Thanks Xiaoyu for the clarification. |
@frischHWC could you please rebase/resolve conflicts? Thank you. |
@dineshchitlangia : updated with master this branch.
|
Thanks @frischHWC for the update, @cku328 @dineshchitlangia @flirmnave and @xiaoyuyao for the review, @elek for triggering CI and cleaning the title. |
What changes were proposed in this pull request?
Setting GDPR to security submenu for EN & CN pages.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4258
How was this patch tested?
Locally with 'hugo serve', see attached screenshot: