Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-4258. Set GDPR to a Security submenu in EN and CN document #1524

Merged
merged 4 commits into from Feb 2, 2021

Conversation

frischHWC
Copy link
Contributor

What changes were proposed in this pull request?

Setting GDPR to security submenu for EN & CN pages.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-4258

How was this patch tested?

Locally with 'hugo serve', see attached screenshot:

Screenshot 2020-10-27 at 07 18 01

@cku328
Copy link
Contributor

cku328 commented Oct 28, 2020

Thanks @frischHWC for working on this.
When GDPR in Ozone is moved from Features to Security, the description on Features page should be updated, IMHO.

擷取1

@frischHWC
Copy link
Contributor Author

Thanks @cku328 for seeing this.
I then propose to remove it from features, but as there is already one description on security, I am not sure it is useful to put both in Security, or even replace old one, what do you think ?
Moreover, to replace this on Features page, I propose something like: "Ozone features are explained in the following pages. Features such as high availability, topology awareness, metrics tools are detailed in next pages." Any thoughts ?

Copy link
Contributor

@cku328 cku328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @frischHWC for the comment. It sounds good to me.
I think you can replace the description on the Features page with this text, because GDPR in Ozone has been moved to the Security page.

@frischHWC
Copy link
Contributor Author

Thanks @cku328 for quick review, however on CN part, I cannot translate the newly added description of Features and removal of GDPR part.

@elek elek changed the title HDDS-4258.Set GDPR to a Security submenu in EN and CN document HDDS-4258. Set GDPR to a Security submenu in EN and CN document Nov 2, 2020
Copy link
Contributor

@cku328 cku328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Thanks @frischHWC for fixing it.
As for the part on CN translation, I think it can be modified in this issue (HDDS-4184).

@flirmnave
Copy link
Contributor

+1 LGTM.
Thanks @frischHWC for contributing it.

@dineshchitlangia
Copy link
Contributor

GDPR is not a security feature, it is a compliance feature.
That was the reason we never added it under Security when the feature was created.
I do not believe this change is necessary.

@flirmnave
Copy link
Contributor

Thanks for @dineshchitlangia comment.
This is based on @xiaoyuyao suggestion on this comment.
Could @xiaoyuyao please share your advice?

@xiaoyuyao
Copy link
Contributor

Thanks for @dineshchitlangia comment.
This is based on @xiaoyuyao suggestion on this comment.
Could @xiaoyuyao please share your advice?

Thanks @dineshchitlangia for the clarification. Here is my understanding: GDPR itself is a EU regulation. To achieve compliance, Ozone support part of it via security mechanism such as encryption to protect user data privacy and right to be forgotten. From technical point of view, the current implementation can be categorized under the security umbrella. In the future, if we have other part of GDPR(non-security related) implemented in Ozone, we could highlight them separately outside Security.

@dineshchitlangia
Copy link
Contributor

Thanks Xiaoyu for the clarification.
+1 now.

@dineshchitlangia
Copy link
Contributor

@frischHWC could you please rebase/resolve conflicts? Thank you.

@frischHWC
Copy link
Contributor Author

@dineshchitlangia : updated with master this branch.
Do you want me to rebase properly ?
Note that failure tests seem not related:

Error:  Failures: 
Error:    TestStorageContainerManager.testCloseContainerCommandOnRestart:647 
Wanted but not invoked:
eventPublisher.fireEvent(
    TypedEvent{payloadType=CommandForDatanode, name='Datanode_Command'},
    <Close container command matcher>
);
-> at org.apache.hadoop.ozone.TestStorageContainerManager.testCloseContainerCommandOnRestart(TestStorageContainerManager.java:647)
Actually, there were zero interactions with this mock.

@adoroszlai
Copy link
Contributor

Thanks @frischHWC for the update, @cku328 @dineshchitlangia @flirmnave and @xiaoyuyao for the review, @elek for triggering CI and cleaning the title.

@adoroszlai adoroszlai merged commit 23d2182 into apache:master Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants