Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-4156. add hierarchical layout to Chinese doc #1368

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

flirmnave
Copy link
Contributor

What changes were proposed in this pull request?

Add hierarchical layout to Chinese doc

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-4156

How was this patch tested?

Test on local use hugo server.
Screenshot from 2020-08-31 22-40-19

@@ -2,7 +2,7 @@
title: 概念
date: "2017-10-10"
menu: main
weight: 6
weight: 3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please explain the reason why weight is changed here? @flirmnave

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
I see that it weight 3 in english version.
https://github.com/apache/hadoop-ozone/blame/master/hadoop-hdds/docs/content/concept/_index.md#L5
So I change it, Should I change it back?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it is the right thing to do, sorry for not noticing this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s ok.

@iamabug
Copy link
Contributor

iamabug commented Sep 1, 2020

Thanks for the work @flirmnave .

According to what I see in localhost, it seems there are some subpages left.

Also, as for Features menu, I think it is both okay to finish it in a separate PR or in this one.

@flirmnave
Copy link
Contributor Author

Thanks for the work @flirmnave .

According to what I see in localhost, it seems there are some subpages left.

Also, as for Features menu, I think it is both okay to finish it in a separate PR or in this one.

Thanks @iamabug review and comment.
Some of the documents have not been translated into Chinese
So some subpages left.

For Features menu, I have create a Jira issue.
https://issues.apache.org/jira/browse/HDDS-4184

@xiaoyuyao
Copy link
Contributor

LGTM overall. Only have one question: should move the GDPR under the Security not Features. This may apply to the original EN document as well.

@flirmnave
Copy link
Contributor Author

LGTM overall. Only have one question: should move the GDPR under the Security not Features. This may apply to the original EN document as well.

Thanks @xiaoyuyao for the review and comment.
I create a Jira issue HDDS-4258 for move the GDPR under the Security.

Copy link
Contributor

@cku328 cku328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Thanks @flirmnave for working on this.
This PR will make the Chinese docs more friendly.

@elek
Copy link
Member

elek commented Oct 5, 2020

Comments from @xiaoyuyao are addressed (issue is created) and @cku328 also reviewed it (thanks for both)

I don't speak Mandarin well, but merging this now as structure change seems to be ok.

Thanks the contribution @flirmnave

@elek elek merged commit 19cb481 into apache:master Oct 5, 2020
@flirmnave
Copy link
Contributor Author

Thanks for @iamabug @xiaoyuyao @cku328 reviewing and @elek merging.

@flirmnave flirmnave deleted the HDDS-4156 branch October 6, 2020 02:10
errose28 pushed a commit to errose28/ozone that referenced this pull request Oct 6, 2020
errose28 added a commit to errose28/ozone that referenced this pull request Oct 14, 2020
* master: (23 commits)
  HDDS-4122. Implement OM Delete Expired Open Key Request and Response (apache#1435)
  HDDS-4336. ContainerInfo does not persist BCSID (sequenceId) leading to failed replica reports (apache#1488)
  Remove extra serialization from getBlockID (apache#1470)
  HDDS-4262. Use ClientID and CallID from Rpc Client to detect retry requests (apache#1436)
  HDDS-4285. Read is slow due to frequent calls to UGI.getCurrentUser() and getTokens() (apache#1454)
  HDDS-4312. findbugs check succeeds despite compile error (apache#1476)
  HDDS-4311. Type-safe config design doc points to OM HA (apache#1477)
  HDDS-3814. Drop a column family through debug cli tool (apache#1083)
  HDDS-3728. Bucket space: check quotaUsageInBytes when write key and allocate block. (apache#1458)
  HDDS-4316. Upgrade to angular 1.8.0 due to CVE-2020-7676 (apache#1481)
  HDDS-4325. Incompatible return codes from Ozone getconf -confKey (apache#1485). Contributed by Doroszlai, Attila.
  HDDS-4309. Fix inconsistency in recon config keys starting with recon and not ozone (apache#1478)
  HDDS-4310: Ozone getconf broke the compatibility (apache#1475)
  HDDS-4298. Use an interface in Ozone client instead of XceiverClientManager (apache#1460)
  HDDS-4280. Document notable configurations for Recon. (apache#1448)
  HDDS-4156. add hierarchical layout to Chinese doc (apache#1368)
  HDDS-4242. Copy PrefixInfo proto to new project hadoop-ozone/interface-storage (apache#1444)
  HDDS-4264. Uniform naming conventions of Ozone Shell Options. (apache#1447)
  HDDS-4271. Avoid logging chunk content in Ozone Insight (apache#1466)
  HDDS-4299. Display Ratis version with ozone version (apache#1464)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants