-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-4156. add hierarchical layout to Chinese doc #1368
Conversation
@@ -2,7 +2,7 @@ | |||
title: 概念 | |||
date: "2017-10-10" | |||
menu: main | |||
weight: 6 | |||
weight: 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please explain the reason why weight
is changed here? @flirmnave
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
I see that it weight 3 in english version.
https://github.com/apache/hadoop-ozone/blame/master/hadoop-hdds/docs/content/concept/_index.md#L5
So I change it, Should I change it back?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it is the right thing to do, sorry for not noticing this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s ok.
Thanks for the work @flirmnave . According to what I see in localhost, it seems there are some subpages left. Also, as for |
Thanks @iamabug review and comment. For |
LGTM overall. Only have one question: should move the GDPR under the Security not Features. This may apply to the original EN document as well. |
Thanks @xiaoyuyao for the review and comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Thanks @flirmnave for working on this.
This PR will make the Chinese docs more friendly.
Comments from @xiaoyuyao are addressed (issue is created) and @cku328 also reviewed it (thanks for both) I don't speak Mandarin well, but merging this now as structure change seems to be ok. Thanks the contribution @flirmnave |
Thanks for @iamabug @xiaoyuyao @cku328 reviewing and @elek merging. |
* master: (23 commits) HDDS-4122. Implement OM Delete Expired Open Key Request and Response (apache#1435) HDDS-4336. ContainerInfo does not persist BCSID (sequenceId) leading to failed replica reports (apache#1488) Remove extra serialization from getBlockID (apache#1470) HDDS-4262. Use ClientID and CallID from Rpc Client to detect retry requests (apache#1436) HDDS-4285. Read is slow due to frequent calls to UGI.getCurrentUser() and getTokens() (apache#1454) HDDS-4312. findbugs check succeeds despite compile error (apache#1476) HDDS-4311. Type-safe config design doc points to OM HA (apache#1477) HDDS-3814. Drop a column family through debug cli tool (apache#1083) HDDS-3728. Bucket space: check quotaUsageInBytes when write key and allocate block. (apache#1458) HDDS-4316. Upgrade to angular 1.8.0 due to CVE-2020-7676 (apache#1481) HDDS-4325. Incompatible return codes from Ozone getconf -confKey (apache#1485). Contributed by Doroszlai, Attila. HDDS-4309. Fix inconsistency in recon config keys starting with recon and not ozone (apache#1478) HDDS-4310: Ozone getconf broke the compatibility (apache#1475) HDDS-4298. Use an interface in Ozone client instead of XceiverClientManager (apache#1460) HDDS-4280. Document notable configurations for Recon. (apache#1448) HDDS-4156. add hierarchical layout to Chinese doc (apache#1368) HDDS-4242. Copy PrefixInfo proto to new project hadoop-ozone/interface-storage (apache#1444) HDDS-4264. Uniform naming conventions of Ozone Shell Options. (apache#1447) HDDS-4271. Avoid logging chunk content in Ozone Insight (apache#1466) HDDS-4299. Display Ratis version with ozone version (apache#1464) ...
What changes were proposed in this pull request?
Add hierarchical layout to Chinese doc
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4156
How was this patch tested?
Test on local use hugo server.
![Screenshot from 2020-08-31 22-40-19](https://user-images.githubusercontent.com/2565172/91732692-2804f480-ebdb-11ea-860a-a3c8b325f552.png)