Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HDDS-4727. [FSO]OMConfig: Modify 'ozone.om.layout.version' config #2118

Merged
merged 2 commits into from Apr 7, 2021
Merged

HDDS-4727. [FSO]OMConfig: Modify 'ozone.om.layout.version' config #2118

merged 2 commits into from Apr 7, 2021

Conversation

sadanand48
Copy link
Contributor

What changes were proposed in this pull request?

Modify 'ozone.om.layout.version' config and respective classes to FSO feature specific

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-4727

How was this patch tested?

CI

rakeshadr
rakeshadr reviewed Apr 6, 2021
View reviewed changes
Copy link
Contributor

@rakeshadr rakeshadr left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sadanand48 for taking this jira ahead. Could you please modify the config name in yaml file as well. I've pushed PR-2071 recently to the branch.

rakeshadr
rakeshadr reviewed Apr 6, 2021
View reviewed changes
Copy link
Contributor

@rakeshadr rakeshadr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few comments, please take care.

hadoop-hdds/common/src/main/resources/ozone-default.xml Outdated Show resolved Hide resolved
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/OMConfigKeys.java Outdated Show resolved Hide resolved
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/OMConfigKeys.java Outdated Show resolved Hide resolved
@rakeshadr rakeshadr changed the title [FSO]OMConfig: Modify 'ozone.om.layout.version' config and respective classes to FSO feature specific HDDS-4727. [FSO]OMConfig: Modify 'ozone.om.layout.version' config Apr 7, 2021
@rakeshadr
Copy link
Contributor

Thanks @sadanand48 for addressing the comments.

+LGTM, I will rebase branch to fix build issues. Will wait for a clean build and then merge it.

@rakeshadr
Copy link
Contributor

Thanks @sadanand48 for addressing the comments.

+LGTM, I will rebase branch to fix build issues. Will wait for a clean build and then merge it.

@sadanand48 I've rebased branch and we need to resolve conflicts in this PR. Please take care.

@sadanand48
Copy link
Contributor Author

Thanks @rakeshadr for the comments . I have rebased the branch.

@rakeshadr
Copy link
Contributor

+1 LGTM, Thanks @sadanand48 for the contribution

@rakeshadr
Copy link
Contributor

Findbug issue is unrelated to this patch and will be fixed via HDDS-5032

@rakeshadr rakeshadr merged commit a7fb5d5 into apache:HDDS-2939 Apr 7, 2021
rakeshadr pushed a commit that referenced this pull request Apr 8, 2021
@sadanand48 @rakeshadr
HDDS-4727. [FSO]OMConfig: Modify 'ozone.om.layout.version' config (#2118
bd22405 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakeshadr rakeshadr rakeshadr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@sadanand48 @rakeshadr