Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HDDS-5695 Review ZK and Curator dependencies, and get rid of them. #2612

Merged
merged 3 commits into from Sep 7, 2021

Conversation

dombizita
Copy link
Contributor

What changes were proposed in this pull request?

Based on testing, ZK and Curator dependencies aren't neccessary anymore.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-5695

How was this patch tested?

Built it without problems.

@fapifta
Copy link
Contributor

fapifta commented Sep 3, 2021

Hi @dombizita thank you for your work on this one. I have merged back the master into HDDS-5447-httpfs branch, and also merged the changes to your PR's branch, in order to have the CI changes and reduce our testing footprint on the branches and PRs whenever it is possible.
Please don't forget to update your local branches.

@fapifta
Copy link
Contributor

fapifta commented Sep 3, 2021

It seems that some of the jars are not removed from jar-report.txt, although they were added in #2536, @dombizita would you mind take a look and check if there is anything else on the list that we can remove after the tests were removed besides removing the unnecessary ones marked by the dependency check? If there is anything that remains, we have to change the LICENSE.txt in hadoop-ozone/dist/src/main/license/bin as well at the end of the day.

Copy link
Contributor

@fapifta fapifta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this one, lgtm, +1.

Note: junit.jar, and json-simple.jar is still on the list in the branch, and not on master.
I am creating a JIRA to track those as well, and as we have json-smart, and we don't need junit we should remove those from the dist dependencies.

@fapifta
Copy link
Contributor

fapifta commented Sep 7, 2021

Created https://issues.apache.org/jira/browse/HDDS-5722 to track the two remaining questionable jars.

@fapifta fapifta merged commit e8b15f4 into apache:HDDS-5447-httpfs Sep 7, 2021
dombizita added a commit to dombizita/ozone that referenced this pull request Sep 22, 2021
fapifta pushed a commit that referenced this pull request Sep 27, 2021
@dombizita dombizita deleted the HDDS-5695 branch March 9, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants