HDDS-5695 Review ZK and Curator dependencies, and get rid of them. #2671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…get rid of them. (apache#2612)" This reverts commit e8b15f4.
|
Hi Zita, thank you for posting the PR, and pointing out the problem with the runtime without these dependencies at the moment. During our discussion we revealed that the DelegationTokenAuthenticationFilter the code is extending from is coming from hadoop, and it is not that easy to remove the dependency on it without further testing. In order to unblock CI, this change is necessary so, +1 to have these back temporarily and deal with them later on. I am merging the change to the branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit e8b15f4.
What changes were proposed in this pull request?
This pull request is reverting the changes in HDDS-5695. Previously the Zookeeper and Curator dependencies were deleted, as we thought they were unnecessary. But later we found out, that in the CI the server couldn't start, because the it is unable to initialize WebAppContext. It happened because the DelegationTokenAuthenticationFilter class is using Zookeeper through curator, as the class is using delegation tokens and the token details are stored in ZooKeeper. So the ZK and the Curator dependencies are needed.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5695
How was this patch tested?
Built it without problems.