HDDS-8737. Organize Ozone admin related Methods into Class OzoneAdmin #4809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adoroszlai
reviewed
Jun 1, 2023
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/HddsDatanodeService.java
Outdated
Show resolved
Hide resolved
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
Outdated
Show resolved
Hide resolved
|
@adoroszlai The checkstyle issue has been fixed. You also can merge the #4794 first if that is needed. I will resolve the conflict. |
adoroszlai
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
Thanks @xichen01 for updating the patch. LGTM, will merge after green CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
There have some duplicate Method, such as
getOzoneAdminsFromConfig,getOzoneAdminsGroupsFromConfigandisAdminetc, This PR will move them to the classOzoneAdminWhat is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-8737
Please replace this section with the link to the Apache JIRA)
How was this patch tested?
The Existing tests