-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-10482. OMRequestTestUtils.createOmKeyInfo should set key modification time #6343
Conversation
LGTM. Build is broken by a recent commit. Let's trigger a rebuild after the broken commit is reverted/fixed. |
225d534
to
d3bfe37
Compare
I've rebased this PR to the master branch before the breaking commit. In order to run CI independent of the breakage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @smengcl for spotting this.
I've rebased this PR to the master branch before the breaking commit. In order to run CI independent of the breakage.
That doesn't work, PRs test patch on top of current master
. Build error is now fixed on master
.
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/TestOmMetadataManager.java
Outdated
Show resolved
Hide resolved
Interesting. The trick works on my fork's branch here: https://github.com/smengcl/hadoop-ozone/actions/runs/8181320975 I guess the PR CI just stick to the master branch when it is posted? Anyway will rebase again. |
d3bfe37
to
61407c8
Compare
Build for |
Thanks @smengcl for the fix. |
Thanks @adoroszlai for the review and comments! |
Thanks @jojochuang for the review as well! |
…ation time (apache#6343) (cherry picked from commit 7c8160f) Change-Id: I40d15e964681a120856c4d5a45e87f811bedcbbb
What changes were proposed in this pull request?
Set mod time in
OMRequestTestUtils.createOmKeyInfo
to fix the regression in test util that caused test failure in a feature branch. See jira description for more backgrounds.What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-10482
How was this patch tested?